Skip to content

[backport release-1.10]: chore: update rag image to upstream 1.10 build (#29)#32

Merged
Jdubrick merged 1 commit into
redhat-ai-dev:release-1.10from
Jdubrick:cherry-pick-rag-1.10
Jun 15, 2026
Merged

[backport release-1.10]: chore: update rag image to upstream 1.10 build (#29)#32
Jdubrick merged 1 commit into
redhat-ai-dev:release-1.10from
Jdubrick:cherry-pick-rag-1.10

Conversation

@Jdubrick

Copy link
Copy Markdown
Contributor

What does this PR do?:

Cherry picks #29 as 1.10.1 is cut

Which issue(s) this PR fixes:

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick Jdubrick requested a review from michael-valdron June 15, 2026 13:19
@qodo-code-review

qodo-code-review Bot commented Jun 15, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Informational

1. Misleading README reference 🐞 Bug ⚙ Maintainability
Description
The updated vector_store_id line in llama-stack-configs/config.yaml says “see readme for this
value”, but the llama-stack-configs README does not describe how to obtain/update the
vector_store_id. This can misdirect contributors away from the actual instructions in
docs/CONTRIBUTING.md.
Code

llama-stack-configs/config.yaml[191]

+    - vector_store_id: vs_757285d9-b657-4bed-b18c-3359844e8c0d # see readme for this value
Evidence
The config line explicitly references a README, but the README in that directory contains no
vector_store_id guidance; the contributing guide contains the actual step-by-step instructions for
locating the ID in the unpacked rag-content and updating config.yaml.

llama-stack-configs/config.yaml[188-194]
llama-stack-configs/README.md[1-7]
docs/CONTRIBUTING.md[56-80]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`llama-stack-configs/config.yaml` includes a comment `# see readme for this value` next to `vector_store_id`, but `llama-stack-configs/README.md` does not contain the referenced guidance. The actual instructions are in `docs/CONTRIBUTING.md`.

### Issue Context
This PR updates the `vector_store_id`, touching the line that contains the misleading comment.

### Fix Focus Areas
- llama-stack-configs/config.yaml[191-191]
- llama-stack-configs/README.md[1-7]
- docs/CONTRIBUTING.md[56-80]

### Suggested fix
- Update the inline comment to point to the real doc section, e.g. `# see docs/CONTRIBUTING.md#configuring-rag-content`.
- (Optional) Add a short sentence to `llama-stack-configs/README.md` pointing readers to the same contributing section for vector store ID updates.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Backport: bump rag-content image and RHDH docs vector store to 1.10
⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

Walkthroughs

Description
• Update rag-content container image reference to the upstream 1.10 build.
• Point RAG SQLite/FAISS storage path at the 1.10 RHDH product docs index.
• Refresh vector_store_id to match the updated 1.10 rag-content dataset.
Diagram
graph TD
  A["env/default-values.env"] --> B(["rag-content image: release-1.10"])
  C["images.yaml"] --> B
  D["llama-stack-configs/config.yaml"] --> E[("FAISS DB: rhdh docs 1.10")]
  D --> F(["vector_store_id updated"])

  subgraph Legend
    direction LR
    _file["Config file"] ~~~ _img(["Container image"]) ~~~ _db[("Database path")]
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Single source of truth for rag-content image/tag
  • ➕ Avoids drift between env/default-values.env and images.yaml
  • ➕ Reduces future backport/cherry-pick conflicts for version bumps
  • ➖ Requires small refactor/templating (e.g., generate env from images.yaml or vice versa)
  • ➖ Likely out-of-scope for a minimal backport PR

Recommendation: For this backport, the current approach (explicitly updating both config locations plus the Llama Stack pointers) is appropriate and minimizes behavioral surprises. Consider a follow-up to consolidate image pinning into a single source of truth to prevent mismatched rag-content versions across deployment entrypoints.

Grey Divider

File Changes

Other (3)
default-values.env Bump RAG_CONTENT_IMAGE to release-1.10 rag-content build +1/-1

Bump RAG_CONTENT_IMAGE to release-1.10 rag-content build

• Updates the default environment variable used to select the rag-content container image. This aligns the deployment with the upstream 1.10 rag-content build tag.

env/default-values.env


images.yaml Update rag-content image tag to upstream 1.10 build +1/-1

Update rag-content image tag to upstream 1.10 build

• Refreshes the rag-content image reference in the repository’s image mapping file to the release-1.10 build tag. Keeps component image definitions consistent with the backport target.

images.yaml


config.yaml Point RAG storage and vector store registration to 1.10 dataset +2/-2

Point RAG storage and vector store registration to 1.10 dataset

• Updates the kv_rag db_path to the 1.10 RHDH product docs FAISS store location. Also changes the registered vector_store_id to the value corresponding to the updated 1.10 rag-content dataset.

llama-stack-configs/config.yaml


Grey Divider

Qodo Logo

@Jdubrick Jdubrick merged commit 997a6fd into redhat-ai-dev:release-1.10 Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants