Skip to content

feat: skills catalog REST API — list, detail, search, Fuse.js, error handler (tasks 5.1-5.3, 5.5-5.7) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnmcollier merged 2 commits into from
Jun 19, 2026
Merged

feat: skills catalog REST API — list, detail, search, Fuse.js, error handler (tasks 5.1-5.3, 5.5-5.7) #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e37ba0
fix: align test 6.4.3 assertion with Epic 5 branch contract (INGEST_F…
johnmcollier Jun 19, 2026
fe8d845
fix: correct test 6.4.3 assertion after rebase onto main (CLONE_FAILED)
johnmcollier Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/server/routes/sources.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ describe("Source Management API", () => {
expect(body.error.code).toBe("SLUG_CONFLICT");
});

it("6.4.3 — clone failure → 422 CLONE_FAILED, no orphan source in DB", async () => {
it("6.4.3 — clone failure → 422 CLONE_FAILED, no source record created", async () => {
const countBefore = repos.sources.findAll().length;

const res = await app.inject({
Expand All @@ -112,7 +112,7 @@ describe("Source Management API", () => {
const body = res.json();
expect(body.error.code).toBe("CLONE_FAILED");

// Source record must not exist — no orphan
// No source record created — clone-before-create guarantees this
expect(repos.sources.findAll().length).toBe(countBefore);
expect(repos.sources.findBySlug("clone-fail-test")).toBeUndefined();
});
Expand Down
Loading