update: OpenShift AI #342
Merged
update: OpenShift AI #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zdtsw
commented
Nov 24, 2024
zdtsw
commented
- add new channel for 2.13 and 2.16 on stable and EUS
- add new components: trustyai and modelregistry
- remove wait on CRD which is not from servicemesh
- update default cert type in kserve since 2.13 changed as patch
- update DSC CR name "default-dsc"
- update README and INFO
- add defaultdeployment serverless in serving patch
- add new channel for 2.13 and 2.16 on stable and EUS - add new components: trustyai and modelregistry - remove wait on CRD which is not from servicemesh - update default cert type in kserve since 2.13 changed as patch - update DSC CR name "default-dsc" - update README and INFO - add defaultdeployment serverless in serving patch Signed-off-by: Wen Zhou <wenzhou@redhat.com>
strangiato
requested changes
Nov 26, 2024
Contributor
strangiato
left a comment
strangiato
left a comment
There was a problem hiding this comment.
Hey @zdtsw, thank you for your contribution! It is always great to see engineering contributing here!
It looks like the linting actions flagged some issues that will need to be resolved. Some of the actions have added annotations directly to the issues. Some like the kustomize check you will need to view the flagged issues in the action.
I also threw a few comments on a few items as well.
The spelling issues tend to cause the most confusion. If the word is spelled correctly and is still having issues it can be added to the wordlist file to bypass the check.
Let me know if you have any issues and I would be happy to help!
rhods-operator/instance/components/components-modelregistry/README.md
Outdated
Show resolved
Hide resolved
rhods-operator/instance/components/components-serving/patch-datasciencecluster.yaml
Show resolved
Hide resolved
rhods-operator/instance/components/components-trustyai/README.md
Outdated
Show resolved
Hide resolved
- lint in yaml - wrong file name - update component name in newly added README - revert DSC CR name back to "default" to not break existing users - update .wordlist-md Signed-off-by: Wen Zhou <wenzhou@redhat.com>
strangiato
approved these changes
Dec 9, 2024
Contributor
strangiato
left a comment
strangiato
left a comment
There was a problem hiding this comment.
lgtm!
Thank you for the great updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.