fix(makefile): Improve performance of make lint#1059
Merged
Conversation
Member
|
/retest |
Collaborator
Author
|
Can we move on with this? It was merged in the upstream operator already. |
keithchong
approved these changes
Feb 6, 2026
Contributor
|
Hi @svghadi , I don't have write access to this repo - adding you to review and approve. |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
olivergondza
force-pushed
the
speedup-lint
branch
from
bbe0cf7 to
acbb81d
Compare
Collaborator
Author
|
Rebased to merge cleanly. PTAL, @svghadi |
Member
|
/lgtm |
Collaborator
Author
|
This should not influence the test execution in any way... |
olivergondza
force-pushed
the
speedup-lint
branch
from
acbb81d to
3c44c3b
Compare
|
New changes are detected. LGTM label has been removed. |
olivergondza
force-pushed
the
speedup-lint
branch
from
3c44c3b to
1c5fb0b
Compare
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
olivergondza
force-pushed
the
speedup-lint
branch
from
1c5fb0b to
c42259c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Same change now done in argo-cd: argoproj/argo-cd#26025
What does this PR do / why we need it:
lint is sped up from 46s to 15s
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: