chore: Drop unneeded nolint annotations#1071
Conversation
Not needed after redhat-developer#973 Signed-off-by: Oliver Gondža <ogondza@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@olivergondza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
LGTM, thanks @olivergondza! A much better solution than when I originally added all those annotations 🎉
I have confirmed that both VS code and golangci-lint are happy after the change.
|
Merging with v4.14 E2E tests failing, as these are currently expected to fail. |
Not needed after #973
What type of PR is this?
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Lint should not complain