Skip to content

chore: Drop unneeded nolint annotations#1071

Merged
jgwest merged 1 commit into
redhat-developer:masterfrom
olivergondza:drop-lint-ignore
Feb 18, 2026
Merged

chore: Drop unneeded nolint annotations#1071
jgwest merged 1 commit into
redhat-developer:masterfrom
olivergondza:drop-lint-ignore

Conversation

@olivergondza

Copy link
Copy Markdown
Collaborator

Not needed after #973

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Lint should not complain

Not needed after redhat-developer#973

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@openshift-ci openshift-ci Bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process. label Feb 13, 2026
@openshift-ci

openshift-ci Bot commented Feb 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olivergondza

Copy link
Copy Markdown
Collaborator Author

/retest

@openshift-ci

openshift-ci Bot commented Feb 13, 2026

Copy link
Copy Markdown

@olivergondza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-parallel 24118a7 link false /test v4.14-kuttl-parallel
ci/prow/v4.14-e2e 24118a7 link true /test v4.14-e2e
ci/prow/v4.14-kuttl-sequential 24118a7 link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgwest jgwest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @olivergondza! A much better solution than when I originally added all those annotations 🎉

I have confirmed that both VS code and golangci-lint are happy after the change.

@jgwest

jgwest commented Feb 18, 2026

Copy link
Copy Markdown
Member

Merging with v4.14 E2E tests failing, as these are currently expected to fail.

@jgwest jgwest merged commit c67f512 into redhat-developer:master Feb 18, 2026
12 of 16 checks passed
@olivergondza olivergondza deleted the drop-lint-ignore branch February 18, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants