Update argocd-operator commit id to get dex changes#1161
Conversation
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates Go module dependency versions across ChangesDependency version updates
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
go.mod (1)
1-33:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRun e2e with real Kubernetes access for the bumped test deps (unit tests passed)
go test ./... -shortsucceeds for controller/unit packages, but all e2e suites fail inBeforeSuitedue to missing Kubernetes configuration (KUBERNETES_SERVICE_HOST/KUBERNETES_SERVICE_PORTorKUBERNETES_MASTER) and, for OpenShift e2e, missingkubectlin$PATH(e.g.,test/e2e/suite_test.go:112,test/nondefaulte2e/suite_test.go:98,test/openshift/e2e/ginkgo/fixture/utils/fixtureUtils.go:41).- The PR acceptance criteria for Unit/E2E were unchecked; e2e couldn’t meaningfully validate the dependency bump in this environment.
Provide CI logs (or rerun) that execute e2e suites in an environment with working kubeconfig/in-cluster access and
kubectl, or gate e2e so it only runs when the required cluster setup is present.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` around lines 1 - 33, E2E suites fail because CI runs them without cluster access or kubectl; update CI and tests so e2e only run when a kubeconfig/cluster and kubectl are present. In CI, add a job step that provision/uses a real cluster or sets KUBECONFIG/KUBERNETES_SERVICE_HOST+KUBERNETES_SERVICE_PORT (or KUBERNETES_MASTER) and ensures kubectl is in PATH before running test/e2e/suite_test.go and test/nondefaulte2e/suite_test.go; alternatively modify the tests' BeforeSuite (see BeforeSuite in test/e2e/suite_test.go and test/nondefaulte2e/suite_test.go and the kubectl check in test/openshift/e2e/ginkgo/fixture/utils/fixtureUtils.go) to detect missing env vars or missing kubectl and gracefully skip the e2e suites, emitting CI-friendly messages so PR gating and acceptance criteria reflect only unit tests unless cluster prerequisites are supplied.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 8: Update the PR title and description to reflect all dependency bumps
listed in go.mod—explicitly mention github.com/argoproj-labs/argocd-operator
v0.17.0-rc1.0.20260502030934-3a9dc793f0c8, github.com/onsi/ginkgo/v2 v2.28.2,
and go.uber.org/zap v1.28.0; for each (argocd-operator, ginkgo/v2, zap) add
authoritative links to the exact commit/tag/changelog for the bumped version and
note any relevant release notes, then run and report compatibility checks
(unit/integration test suite, API surface usage checks) against our code paths
referencing functions/types from argocd-operator, ginkgo (test harness), and zap
(logging) to catch breaking changes, and include a short security assessment
summarizing the securityVulnerabilities GraphQL query results plus any
additional dependency scanning output.
---
Outside diff comments:
In `@go.mod`:
- Around line 1-33: E2E suites fail because CI runs them without cluster access
or kubectl; update CI and tests so e2e only run when a kubeconfig/cluster and
kubectl are present. In CI, add a job step that provision/uses a real cluster or
sets KUBECONFIG/KUBERNETES_SERVICE_HOST+KUBERNETES_SERVICE_PORT (or
KUBERNETES_MASTER) and ensures kubectl is in PATH before running
test/e2e/suite_test.go and test/nondefaulte2e/suite_test.go; alternatively
modify the tests' BeforeSuite (see BeforeSuite in test/e2e/suite_test.go and
test/nondefaulte2e/suite_test.go and the kubectl check in
test/openshift/e2e/ginkgo/fixture/utils/fixtureUtils.go) to detect missing env
vars or missing kubectl and gracefully skip the e2e suites, emitting CI-friendly
messages so PR gating and acceptance criteria reflect only unit tests unless
cluster prerequisites are supplied.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: adb359ef-e62b-49d4-aa8b-94beb5fa8717
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
|
/retest |
1 similar comment
|
/retest |
|
@Rizwana777: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What type of PR is this?
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: