update argocd-operator crd and dep #887
Merged
jgwest merged 2 commits intoMay 9, 2025
Merged
Conversation
Member
|
Can you run make generate manifests bundleto fix the CI? |
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
anandrkskd
force-pushed
the
pull-field-deprecation-changes
branch
from
4856b7e to
dfcf01b
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/test v4.17-kuttl-parallel |
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
jgwest
approved these changes
May 8, 2025
jgwest
left a comment
jgwest
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @anandrkskd , +1 for the 1-083 fix, I likewise found this change was required.
Member
|
/retest |
Member
|
/lgtm |
Contributor
Author
|
Thanks, @jgwest for review! |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgwest The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
varshab1210
pushed a commit
to nmirasch/gitops-operator
that referenced
this pull request
Jul 23, 2025
* update dep argocd-operator and crd Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix failing test Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> --------- Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR pulls latest argocd-operator and crd, to verify deprecation of initial-repositories and repositoriesCredential fields.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #GITOPS-6652
Test acceptance criteria:
How to test changes / Special notes to the reviewer: