Skip to content

feat: watch and reconcile updates to the admin clusterrole#913

Merged
jgwest merged 2 commits into
redhat-developer:masterfrom
chetan-rns:watch-cluster-admin
Aug 12, 2025
Merged

feat: watch and reconcile updates to the admin clusterrole#913
jgwest merged 2 commits into
redhat-developer:masterfrom
chetan-rns:watch-cluster-admin

Conversation

@chetan-rns

Copy link
Copy Markdown
Member

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Currently, we copy the rules from the admin cluster role when creating the application controller role. However, any updates to the admin cluster role are not synced to the application controller cluster role. So, the application controller may not have permissions to manage certain resources until the next reconciliation cycle.

Dependent on: argoproj-labs/argocd-operator#1775

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-6367

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

  1. Run the operator
  2. Create a namespace with the managed-by label
  3. Install any operator or aggregate any CRDs to the admin cluster role
  4. Observe if the application controller role is updated to manage the new CRDs

@openshift-ci

openshift-ci Bot commented Jul 7, 2025

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the kind/enhancement New feature or request label Jul 7, 2025
@openshift-ci

openshift-ci Bot commented Jul 7, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chetan-rns chetan-rns force-pushed the watch-cluster-admin branch from 743b964 to 36997d3 Compare July 28, 2025 04:37
@chetan-rns chetan-rns marked this pull request as ready for review July 28, 2025 06:19
@openshift-ci openshift-ci Bot requested review from jgwest and trdoyle81 July 28, 2025 06:19
@chetan-rns chetan-rns marked this pull request as draft July 28, 2025 11:42
@chetan-rns chetan-rns force-pushed the watch-cluster-admin branch from 36997d3 to 1989ffd Compare August 11, 2025 15:13
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
@chetan-rns chetan-rns force-pushed the watch-cluster-admin branch from 1989ffd to 89df603 Compare August 11, 2025 15:15
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
@chetan-rns chetan-rns marked this pull request as ready for review August 11, 2025 17:07
@openshift-ci openshift-ci Bot requested review from jannfis and svghadi August 11, 2025 17:07
@chetan-rns

Copy link
Copy Markdown
Member Author

/test v4.17-kuttl-sequential

@jgwest jgwest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chetan-rns!

@jgwest jgwest merged commit ef0cfb0 into redhat-developer:master Aug 12, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants