feat: watch and reconcile updates to the admin clusterrole#913
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
743b964 to
36997d3
Compare
36997d3 to
1989ffd
Compare
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
1989ffd to
89df603
Compare
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Member
Author
|
/test v4.17-kuttl-sequential |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Currently, we copy the rules from the admin cluster role when creating the application controller role. However, any updates to the admin cluster role are not synced to the application controller cluster role. So, the application controller may not have permissions to manage certain resources until the next reconciliation cycle.
Dependent on: argoproj-labs/argocd-operator#1775
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-6367
Test acceptance criteria:
How to test changes / Special notes to the reviewer: