Skip to content

add ginkgo testing for Enable ApplicationFineGrainedRBACInheritance by default#916

Closed
nmirasch wants to merge 1 commit into
redhat-developer:masterfrom
nmirasch:GITOPS-6889_migrate_test_to_ginkgo
Closed

add ginkgo testing for Enable ApplicationFineGrainedRBACInheritance by default#916
nmirasch wants to merge 1 commit into
redhat-developer:masterfrom
nmirasch:GITOPS-6889_migrate_test_to_ginkgo

Conversation

@nmirasch

@nmirasch nmirasch commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

GITOPS-6889

What type of PR is this?
This PR ports 1-018_validate_extra_config/06-override-rbac-inheritance-using-extraconfig.yaml to Ginkgo test

/kind enhancement

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci Bot added the kind/enhancement New feature or request label Jul 8, 2025
@openshift-ci openshift-ci Bot requested review from anandrkskd and jgwest July 8, 2025 10:12
@openshift-ci

openshift-ci Bot commented Jul 8, 2025

Copy link
Copy Markdown

Hi @nmirasch. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@varshab1210

Copy link
Copy Markdown
Member

/ok-to-test

@nmirasch nmirasch force-pushed the GITOPS-6889_migrate_test_to_ginkgo branch from 8cfcda6 to 32e7795 Compare July 25, 2025 07:20
@nmirasch nmirasch force-pushed the GITOPS-6889_migrate_test_to_ginkgo branch from 32e7795 to 9458407 Compare September 17, 2025 10:15
@nmirasch nmirasch force-pushed the GITOPS-6889_migrate_test_to_ginkgo branch from 9458407 to b2c91fe Compare October 1, 2025 16:52
@nmirasch nmirasch force-pushed the GITOPS-6889_migrate_test_to_ginkgo branch 2 times, most recently from 9f26e4a to 1374331 Compare October 13, 2025 12:12
@nmirasch

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@nmirasch

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci

openshift-ci Bot commented Oct 15, 2025

Copy link
Copy Markdown

@nmirasch: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 1374331 link true /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

…y default (GITOPS-6889)

Signed-off-by: nmirasch <neus.miras@gmail.com>
@nmirasch nmirasch force-pushed the GITOPS-6889_migrate_test_to_ginkgo branch from 1374331 to b4c182e Compare March 24, 2026 14:23
@openshift-ci

openshift-ci Bot commented Mar 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmirasch nmirasch closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants