Skip to content

Introduce new label on operator managed configmap#934

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:masterfrom
alkakumari016:GITOPS-7334
Aug 14, 2025
Merged

Introduce new label on operator managed configmap#934
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:masterfrom
alkakumari016:GITOPS-7334

Conversation

@alkakumari016

Copy link
Copy Markdown
Contributor

What type of PR is this?
Introduce new label on operator managed configmap

Which issue(s) this PR fixes:

Fixes #?
https://issues.redhat.com/browse/GITOPS-7334

How to test changes / Special notes to the reviewer:

@openshift-ci

openshift-ci Bot commented Jul 30, 2025

Copy link
Copy Markdown

Hi @alkakumari016. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi

svghadi commented Jul 30, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@alkakumari016

Copy link
Copy Markdown
Contributor Author

/retest

@jgwest jgwest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-043_validate_custom_labels_annotations is failing because argoproj-labs/argocd-operator#1737 broke the ability to remove custom labels from deployments/statefulsets. (I git bisected the argocd-operator commits)

@alkakumari016

Copy link
Copy Markdown
Contributor Author

1-043_validate_custom_labels_annotations is failing because argoproj-labs/argocd-operator#1737 broke the ability to remove custom labels from deployments/statefulsets. (I git bisected the argocd-operator commits)

Thanks @jgwest for taking a look. I'm trying to resolve this bug and tracking it as part of https://issues.redhat.com/browse/GITOPS-7405.

Signed-off-by: Alka Kumari <alkumari@redhat.com>
@svghadi

svghadi commented Aug 14, 2025

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Aug 14, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svghadi

svghadi commented Aug 14, 2025

Copy link
Copy Markdown
Member

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit 55e8033 into redhat-developer:master Aug 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants