Update to latest commit of argo-rollouts-manager 'a100fc1d88b8e3eee5d0d31a8be2956f96005d77' and argocd-operator '5135028d69782184553b57088981c72125aa77d7'#941
Merged
Conversation
…0d31a8be2956f96005d77' Signed-off-by: Jonathan West <jonwest@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jgwest
force-pushed
the
upgrade-rollouts-manager
branch
4 times, most recently
from
18dec8f to
0ed979c
Compare
Signed-off-by: Jonathan West <jonwest@redhat.com>
jgwest
force-pushed
the
upgrade-rollouts-manager
branch
from
0ed979c to
69a0511
Compare
jgwest
changed the title
jgwest
changed the title
chetan-rns
approved these changes
Aug 11, 2025
| setupLog.Info(fmt.Sprintf("Component registered: %v", reflect.ValueOf(f))) | ||
| } | ||
|
|
||
| func initK8sClient() (*kubernetes.Clientset, error) { |
Member
There was a problem hiding this comment.
Nit: We could move this function to a different package so that it can be reused everywhere. There's already a similar function here.
Member
Author
There was a problem hiding this comment.
Agreed, thanks @chetan-rns! I will follow up with this on a separate PR.
Member
Author
|
Thanks for reviewing @chetan-rns! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to most recent 'argo-rollouts-manager' commit: argoproj-labs/argo-rollouts-manager@a100fc1
Update to the most recent ''argocd-operator' commit: argoproj-labs/argocd-operator@5135028
Some additional gitops-operator changes were required due to Namespace Management feature added to argocd-operator. I made them as part of this PR.