Skip to content

fix: Add controller-gen to CI build root image#942

Closed
aali309 wants to merge 0 commit into
redhat-developer:masterfrom
aali309:fixTestFailures
Closed

fix: Add controller-gen to CI build root image#942
aali309 wants to merge 0 commit into
redhat-developer:masterfrom
aali309:fixTestFailures

Conversation

@aali309

@aali309 aali309 commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

What type of PR is this?

This change adds controller-gen to the CI build root image.

/kind bug

What does this PR do / why we need it:
This change adds controller-gen to the CI build root image to fix test failures when running with GOFLAGS=-mod=vendor. Previously, the CI environment would fail when trying to download controller-gen during test execution due to
the vendor flag preventing module downloads.
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci

openshift-ci Bot commented Aug 7, 2025

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@aali309 aali309 marked this pull request as ready for review August 7, 2025 21:54
@aali309 aali309 closed this Aug 7, 2025
@aali309 aali309 deleted the fixTestFailures branch August 7, 2025 22:49
@openshift-ci

openshift-ci Bot commented Aug 7, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 7, 2025

Copy link
Copy Markdown

@aali309: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.17-e2e 9af14fe link true /test v4.17-e2e
ci/prow/v4.14-kuttl-sequential 9af14fe link true /test v4.14-kuttl-sequential
ci/prow/v4.14-kuttl-parallel 9af14fe link true /test v4.14-kuttl-parallel
ci/prow/v4.14-e2e 9af14fe link true /test v4.14-e2e
ci/prow/v4.17-kuttl-sequential 9af14fe link true /test v4.17-kuttl-sequential
ci/prow/v4.17-kuttl-parallel 9af14fe link true /test v4.17-kuttl-parallel
ci/prow/unit 2f4984c link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant