chore: Update to latest commit of argocd-operator: 80f37522108a42db5bdb5d5c13403a4090b94c6f#947
Conversation
…db5d5c13403a4090b94c6f Signed-off-by: Jonathan West <jonwest@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
LGTM Thank you @jgwest . Just one question - I see the kuttl E2E tests related to Keycloak are still present. Is it fine to keep them now that we’ve switched to Ginkgo tests? https://github.com/redhat-developer/gitops-operator/blob/master/test/openshift/e2e/parallel/1-073_validate_rhsso/01-argocd-rhsso.yaml , https://github.com/redhat-developer/gitops-operator/blob/master/test/openshift/e2e/sequential/1-050_validate_sso/07-provider-keycloak-dex-spec.yaml |
|
Hey @Rizwana777, yah, I think we'll get rid of them soon. We're not going to maintain them anymore. I just want to make sure that QE team is OK with permanently removing them before we do. |
|
Thanks @Rizwana777! |
What type of PR is this?
What does this PR do / why we need it:
Have you updated the necessary documentation?