Add e2e tests for namespaceManagement#948
Merged
jgwest merged 6 commits intoSep 9, 2025
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
4 times, most recently
from
89ccae8 to
200cda1
Compare
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
from
200cda1 to
e0ae579
Compare
Rizwana777
changed the title
jgwest
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
from
b97a313 to
6cd2e65
Compare
Member
|
/retest |
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
from
6cd2e65 to
9a1ec72
Compare
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
4 times, most recently
from
8f4b681 to
dbd3d1e
Compare
Collaborator
Author
|
/retest |
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
5 times, most recently
from
1df0f8d to
5fb4411
Compare
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
from
e27656b to
207f640
Compare
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
from
207f640 to
b880099
Compare
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
2 times, most recently
from
86158d8 to
c7e7141
Compare
Collaborator
Author
|
/retest |
Rizwana777
changed the title
jgwest
requested changes
Sep 2, 2025
jgwest
left a comment
jgwest
left a comment
Member
There was a problem hiding this comment.
I've also pushed a commit to your PR that adds some additional Consistently checks alongside the Eventually checks, to detect race conditions.
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
from
96ddc18 to
1addf7f
Compare
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
from
1addf7f to
e3f2a18
Compare
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Rizwana777
force-pushed
the
issue-7366-namespaceManagement-e2e-tests
branch
from
e3f2a18 to
b83ffdb
Compare
Member
|
/retest |
Member
|
/cherry-pick v1.18 |
Contributor
|
@jgwest: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
/cherry-pick v1.18 |
Contributor
|
@jgwest: #948 failed to apply on top of branch "v1.18": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jgwest
added a commit
to jgwest/gitops-operator
that referenced
this pull request
Sep 9, 2025
* Add e2e tests for namespaceManagement Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com> * Add namespacemanagement/status to RBAC, and tweak test contents Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com> * Fix merge conflicts Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com> * Add remaining namespaceManagement tests Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com> * Add additional Consistently checks Signed-off-by: Jonathan West <jonwest@redhat.com> * Add a new test and address review comments Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com> --------- Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com> Signed-off-by: Jonathan West <jonwest@redhat.com> Co-authored-by: Jonathan West <jonwest@redhat.com>
jgwest
added a commit
that referenced
this pull request
Sep 9, 2025
* Add e2e tests for namespaceManagement * Add namespacemanagement/status to RBAC, and tweak test contents * Fix merge conflicts * Add remaining namespaceManagement tests * Add additional Consistently checks * Add a new test and address review comments --------- Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com> Signed-off-by: Jonathan West <jonwest@redhat.com> Co-authored-by: Rizwana Naaz <rizwananaaz177@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA - https://issues.redhat.com/browse/GITOPS-7366