Fix: Skip error log when console link is disabled and absent

[nmirasch]

What type of PR is this?
/kind bug

What does this PR do / why we need it:
This PR removes misleading error logs that appeared when the environment variable DISABLE_DEFAULT_ARGOCD_CONSOLELINK was set to true and the ConsoleLink resource did not exist before.

Previously, the operator logged an error in this scenario even though the behavior was correct and no real issue occurred. This could confuse users and clutter the logs.
The operator now skips logging an error when the ConsoleLink is disabled and not present, ensuring logs only reflect actual problems.

Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes: https://issues.redhat.com/browse/GITOPS-7331

Test acceptance criteria:

• Unit Test
• E2E Test

How to test changes / Special notes to the reviewer:

[openshift-ci]

Hi @nmirasch. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jgwest]

/ok-to-test

[svghadi]

/lgtm

[anandf]

LGTM

[svghadi]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [svghadi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[svghadi]

/cherry-pick v1.18

[openshift-cherrypick-robot]

@svghadi: once the present PR merges, I will cherry-pick it on top of v1.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[svghadi]

/cherry-pick v1.17

[openshift-cherrypick-robot]

@svghadi: once the present PR merges, I will cherry-pick it on top of v1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@svghadi: new pull request created: #954

Details

In response to this:

/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@svghadi: #949 failed to apply on top of branch "v1.17":

Applying: Skip error log when console link is disabled and absent
Using index info to reconstruct a base tree...
M	controllers/argocd_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/argocd_controller_test.go
CONFLICT (content): Merge conflict in controllers/argocd_controller_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Skip error log when console link is disabled and absent

Details

In response to this:

/cherry-pick v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.