added ginkgo test for Banner property of argocd

[alkakumari016]

What type of PR is this?

/kind-test

What does this PR do / why we need it:

Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
GITOPS-7712

How to test changes / Special notes to the reviewer:

[openshift-ci]

Hi @alkakumari016. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[svghadi]

/ok-to-test

[svghadi]

@alkakumari016 - What do you think about combining all the test scenarios in a single IT, instead of creating multiple ITs, which creates multiple ArgoCD instances.

The test can follow below sequence

1. Create Banner with all support configs in ArgoCD CR
2. Check if it is reflected in argocd-cm
3. Update some banner properties in ArgoCD CR
4. Check if new values are reflected in argocd-cm and old are preserved
5. Remove the banner from ArgoCD CR
6. Check if corresponding configs are removed from argocd-cm

[alkakumari016]

@alkakumari016 - What do you think about combining all the test scenarios in a single IT, instead of creating multiple ITs, which creates multiple ArgoCD instances.

The test can follow below sequence

1. Create Banner with all support configs in ArgoCD CR
2. Check if it is reflected in argocd-cm
3. Update some banner properties in ArgoCD CR
4. Check if new values are reflected in argocd-cm and old are preserved
5. Remove the banner from ArgoCD CR
6. Check if corresponding configs are removed from argocd-cm

@svghadi I have merged the blocks into one It block and removed some unwanted tests. The sequence looks good and makes sense to remove other scenarios since these are covering pretty much everyuthing. I have updated the PR please take a look.

[alkakumari016]

/retest

[alkakumari016]

/retest

[svghadi]

/lgtm

[svghadi]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [svghadi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alkakumari016]

/retest

[svghadi]

/cherry-pick v1.18

[openshift-cherrypick-robot]

@svghadi: once the present PR merges, I will cherry-pick it on top of v1.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alkakumari016]

/retest

[alkakumari016]

/retest

[openshift-cherrypick-robot]

@svghadi: new pull request created: #968

Details

In response to this:

/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.