Skip to content

[GITOPS-7846]: Feature Changes for Resource requests and limits configurable for Gitops plugin and backend#969

Merged
openshift-merge-bot[bot] merged 34 commits into
redhat-developer:masterfrom
akhilnittala:test_changes_2
Oct 13, 2025
Merged

[GITOPS-7846]: Feature Changes for Resource requests and limits configurable for Gitops plugin and backend#969
openshift-merge-bot[bot] merged 34 commits into
redhat-developer:masterfrom
akhilnittala:test_changes_2

Conversation

@akhilnittala

@akhilnittala akhilnittala commented Sep 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

  1. Can configure the resource requests and limits for gitops plugin and backend, can also update the resource requests and limits.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-7743
Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

  1. For testing resource requests and limits, apply gitops service CR With resource requests and limits in spec section
  2. For cleaning up the cluster backend and gitops plugin, ensure DISABLE_DEFAULT_ARGOCD_CONSOLELINK env variable set to true and verify the CRs, deployments and pods in openshift-gitops namespace

anandf and others added 5 commits September 16, 2025 12:26
@anandf
Added support for resource requirements in GitOpsService
90000c5 
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@anandf
Added initial version of e2e test which needs improvment and addition…
6c230e2 
…al tests

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@anandf
Added generated file
fbdc05b 
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@anandf
Added missing changes for crds and manifests
87327e1 
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@akhilnittala
[GITOPS-7743]: Cluster, gitoops-backend are not getting cleanedup whe…
7587313 
…n disableDefaultinstance is true

Signed-off-by: akhil nittala <nakhil@redhat.com>
@openshift-ci

openshift-ci Bot commented Sep 17, 2025

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akhilnittala
Merge branch 'master' into test_changes_2
ea681da
@akhilnittala
[GITOPS-7743]: Cluster, gitoops-backend are not getting cleanedup whe…
b537dcb 
…n disableDefaultinstance is true

Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
c6ffed5 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
360bdba 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
1016289 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
ac44393 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
2c259c6 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala akhilnittala marked this pull request as ready for review September 19, 2025 04:39
@akhilnittala
Resource requests and limits configurable
1f43602 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
3fe27d8 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
05c5764 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
c6e49f3 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
5bbd786 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
7b11d5c 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala

akhilnittala commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

/retest

@akhilnittala
Resource requests and limits configurable
e5a8fcd 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Merge branch 'master' into test_changes_2
0ac9909
@akhilnittala
Resource requests and limits configurable
87bf422 
Signed-off-by: akhil nittala <nakhil@redhat.com>
anandf
anandf reviewed Oct 1, 2025
View reviewed changes
Comment thread controllers/gitopsservice_controller_test.go
@akhilnittala
Resource requests and limits configurable
652f9c8 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
0198d6e 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
Resource requests and limits configurable
4d2914b 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala

akhilnittala commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

/retest

@akhilnittala akhilnittala changed the title Test changes 2 [GITOPS-7846]: Feature Changes for Resource requests and limits configurable for Gitops plugin and backend Oct 6, 2025
@akhilnittala akhilnittala requested a review from anandf October 6, 2025 06:35
@akhilnittala

akhilnittala commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

/retest

@akhilnittala

akhilnittala commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

/retest-required

@akhilnittala

akhilnittala commented Oct 7, 2025

Copy link
Copy Markdown
Member Author

/retest-required

@akhilnittala

akhilnittala commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

/retest-required

1 similar comment
@akhilnittala

akhilnittala commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

/retest-required

svghadi
svghadi reviewed Oct 9, 2025
View reviewed changes

@svghadi svghadi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akhilnittala! Looks good overall. Left a few comments on the e2e test.

Comment thread test/openshift/e2e/ginkgo/sequential/1-121-valiate_resource_constraints_gitopsservice_test.go
Comment thread test/openshift/e2e/ginkgo/sequential/1-121-valiate_resource_constraints_gitopsservice_test.go Outdated
Comment thread test/openshift/e2e/ginkgo/sequential/1-121-valiate_resource_constraints_gitopsservice_test.go
@akhilnittala

akhilnittala commented Oct 10, 2025

Copy link
Copy Markdown
Member Author

/retest-required

@akhilnittala
Resource requests and limits configurable
fa4c7c2 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@anandf

anandf commented Oct 13, 2025

Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 13, 2025
@openshift-ci

openshift-ci Bot commented Oct 13, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit fac7786 into redhat-developer:master Oct 13, 2025
16 checks passed
@akhilnittala akhilnittala deleted the test_changes_2 branch October 13, 2025 10:03
@svghadi svghadi mentioned this pull request Oct 23, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svghadi svghadi svghadi left review comments

@anandf anandf anandf approved these changes

@Rizwana777 Rizwana777 Awaiting requested review from Rizwana777

@jgwest jgwest Awaiting requested review from jgwest

@keithchong keithchong Awaiting requested review from keithchong

@trdoyle81 trdoyle81 Awaiting requested review from trdoyle81

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@anandf anandf

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akhilnittala @anandf @svghadi