fix(Makefile): Use only tool name to pass opm --container-tool

[olivergondza]

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Running make catalog-build catalog-push fails in a following way on machine with both docker and podman:

./bin/opm index add --container-tool /usr/bin/docker --mode semver --tag quay.io/ogondza/gitops-operator-catalog:v42.42.42 --bundles quay.io/ogondza/gitops-operator-bundle:42.42.42 
...
INFO[0000] building the index                            bundles="[quay.io/ogondza/gitops-operator-bundle:42.42.42]"
INFO[0003] Could not find optional dependencies file     file=bundle_tmp1709541790/metadata load=annotations with=./bundle_tmp1709541790
INFO[0003] Could not find optional properties file       file=bundle_tmp1709541790/metadata load=annotations with=./bundle_tmp1709541790
INFO[0003] Could not find optional dependencies file     file=bundle_tmp1709541790/metadata load=annotations with=./bundle_tmp1709541790
INFO[0003] Could not find optional properties file       file=bundle_tmp1709541790/metadata load=annotations with=./bundle_tmp1709541790
INFO[0003] Generating dockerfile                         bundles="[quay.io/ogondza/gitops-operator-bundle:42.42.42]"
INFO[0003] writing dockerfile: ./index.Dockerfile1405347037  bundles="[quay.io/ogondza/gitops-operator-bundle:42.42.42]"
INFO[0003] running podman build                          bundles="[quay.io/ogondza/gitops-operator-bundle:42.42.42]"
INFO[0003] [podman build --format docker -f ./index.Dockerfile1405347037 -t quay.io/ogondza/gitops-operator-catalog:v42.42.42 .]  bundles="[quay.io/ogondza/gitops-operator-bundle:42.42.42]"
make docker-push IMG=quay.io/ogondza/gitops-operator-catalog:v42.42.42
make[1]: Entering directory '/home/ogondza/code/argo/gitops-operator'
/usr/bin/docker push quay.io/ogondza/gitops-operator-catalog:v42.42.42
The push refers to repository [quay.io/ogondza/gitops-operator-catalog]
An image does not exist locally with the tag: quay.io/ogondza/gitops-operator-catalog
make[1]: *** [Makefile:222: docker-push] Error 1
make[1]: Leaving directory '/home/ogondza/code/argo/gitops-operator'
make: *** [Makefile:362: catalog-push] Error 2

Note it is tagged by podman (despite --container-tool=/usr/bin/docker), so pushing the tag by docker fails for obvious reasons. Turnes out opm ignores path silently, because it expects exact tool name (https://github.com/operator-framework/operator-registry/blob/017ab5353fec264c1fb1381b5d7088bb77b53b82/pkg/containertools/containertool.go#L34).

Have you updated the necessary documentation?

• [no] Documentation update is required by this PR.
• [no] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

• [no] Unit Test
• [no] E2E Test

How to test changes / Special notes to the reviewer:

[olivergondza]

CC @ranakan19, in case you run into the same.

[svghadi]

Thanks @olivergondza for identifying and fix this one. We might also hit this in argocd-operator
https://github.com/argoproj-labs/argocd-operator/blob/5e50bdd28e6e184a2b0a935993c44718627b6eb7/Makefile#L319-L321

[svghadi]

/lgtm
/approve

[svghadi]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [svghadi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment