Skip to content

fix: Fips ssh fix #980

Merged
svghadi merged 2 commits into
redhat-developer:v1.17from
svghadi:fips-1.17
Oct 1, 2025
Merged

fix: Fips ssh fix #980
svghadi merged 2 commits into
redhat-developer:v1.17from
svghadi:fips-1.17

Conversation

@svghadi

@svghadi svghadi commented Oct 1, 2025

Copy link
Copy Markdown
Member

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Cherry-pick #971

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@openshift-ci openshift-ci Bot added the kind/bug Something isn't working label Oct 1, 2025
@openshift-ci openshift-ci Bot requested review from keithchong and trdoyle81 October 1, 2025 05:44
@svghadi

svghadi commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

/retest

@svghadi

svghadi commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

/test v4.17-e2e

@svghadi

svghadi commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

/retest

@svghadi

svghadi commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

/test v4.17-kuttl-parallel

@svghadi

svghadi commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

/retest

@varshab1210

Copy link
Copy Markdown
Member

/rerun-required

@varshab1210

Copy link
Copy Markdown
Member

/retest-required

1 similar comment
@varshab1210

Copy link
Copy Markdown
Member

/retest-required

@openshift-ci

openshift-ci Bot commented Oct 1, 2025

Copy link
Copy Markdown

@svghadi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-parallel 15aecab link true /test v4.14-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi

svghadi commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

/approve

@openshift-ci

openshift-ci Bot commented Oct 1, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svghadi svghadi merged commit 516cce4 into redhat-developer:v1.17 Oct 1, 2025
9 of 10 checks passed
@openshift-ci openshift-ci Bot added the approved label Oct 1, 2025
@svghadi svghadi deleted the fips-1.17 branch October 1, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants