RHDHBUGS-2260: trust corporate-issued certificate#2211
Closed
deerskindoll wants to merge 19 commits into
Closed
Conversation
Collaborator
PR Build ResultsBuild failed -- 32/34 titles | 89s control-access_authentication-in-rhdhError: get-started_setting-up-and-configuring-your-first-red-hat-developer-hub-instanceError: Content Quality AssessmentCQA Report
SummaryChecks: 19 total, 19 pass, 0 fail 19 checks: 19 pass, 0 fail Run Updated 2026-06-07 22:48:28 UTC |
deerskindoll
changed the title
albarbaro
suggested changes
May 18, 2026
deerskindoll
changed the title
albarbaro
approved these changes
Jun 3, 2026
deerskindoll
added
Peer review needed 📖
Technical review done ⛅
rh-tokeefe
approved these changes
Jun 4, 2026
…rporate-certificate-authority-with-node-extra-ca-certs.adoc Co-authored-by: Tim O'Keefe <tokeefe@redhat.com>
…dhat-developer#2302) * Fix book-link xref format and add filecheck procedure Remove leading '#' from book-link attribute xrefs across 104 files to match the correct cross-reference format for external book links. Add Scorecard file-level checks procedure to the Scorecards title. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Revert "Fix book-link xref format and add filecheck procedure" This reverts commit ad9bae2. * RHDHBUGS-3298: Remove SNIPPET attribute from snippets to fix list continuation The :_mod-docs-content-type: SNIPPET attribute at the start of snippet files breaks AsciiDoc list continuation when the snippet is included inside a procedure step with +. The attribute acts as a block boundary, causing the snippet content to escape the step and float after the procedure list, breaking DITA <steps> mapping. CQA identifies snippets by their snip- filename prefix, not by this attribute, so removing it is safe. Also add missing + before the OCI tag snippet include in the Tekton procedure, and re-enable the AsciiDocDITA.TaskInclude Vale rule. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * RHDHBUGS-3298: Wrap step 1 in open block for GitHub aux auth procedure The guest user step snippet has no blank line after its attribute, so the attribute is not the problem here. The issue is that step 1's complex continuation content (definition list + WARNING) prevents step 2 from continuing the numbered list. Wrap step 1 content in an open block (--) so the included step 2 continues the list correctly. Restore the SNIPPET attribute in the guest user snippet since it was not causing list breaks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * RHDHBUGS-3298: Rewrite OCI tag snippet to use where: definition list convention Replace the paragraph + bulleted list format with the project's standard where: + definition list pattern for placeholder explanations. This also helps list continuation since definition lists attach naturally as step content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * RHDHBUGS-3298: Restore SNIPPET attribute without blank line after it The attribute + blank line combination broke list continuation. The attribute alone (without a trailing blank line) is consumed silently by Asciidoctor and does not break the + continuation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * RHDHBUGS-3298: Use 'Enter' for placeholder description per convention Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * RHDHBUGS-3298: Escape double underscores in OCI tag snippet with pass:c,a,q Double underscores in backtick-quoted inline code were interpreted as AsciiDoc emphasis markers, producing invalid DocBook XML that broke ccutil builds for extend_configuring-dynamic-plugins and extend_dynamic-plugins-reference titles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * RHDHBUGS-3298: Inline sha256 tip into OCI snippet and delete orphan The included snip-tag-for-sha256-tip.adoc SNIPPET attribute was leaking as visible text when included after a + list continuation. Inlining the TIP block follows the project where: + definition list convention and removes the orphaned snippet file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * RHDHBUGS-3298: Fix OCI snippet rendering and GitHub auth step numbering Add blank line between where: and definition list so the TIP attaches to the definition list item via +. Remove blank line before guest-user snippet include so step 2 continues the numbered list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Update artifacts/snip-tag-for-OCI-package-paths.adoc Co-authored-by: Priyanka Abel <pabel@redhat.com> * Apply suggestion from @themr0c --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Priyanka Abel <pabel@redhat.com>
…ules (redhat-developer#2302)" This reverts commit e9faa87.
|
Member
Author
|
replaced by #2379 |
Member
Author
|
created PR against release-1.10 branch #2383 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
main, release-1.10
Issue:
https://redhat.atlassian.net/browse/RHDHBUGS-2260
Preview: