Skip to content

fix: Fix the dynamic plugins configuration to work with RHDH 1.9+ [RHDHBUGS-2646]#159

Open
rm3l wants to merge 10 commits intoredhat-developer:release-1.9from
rm3l:fix/fix_startup_issue_with_rhdh_1.9
Open

fix: Fix the dynamic plugins configuration to work with RHDH 1.9+ [RHDHBUGS-2646]#159
rm3l wants to merge 10 commits intoredhat-developer:release-1.9from
rm3l:fix/fix_startup_issue_with_rhdh_1.9

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Feb 11, 2026 •
edited
Loading

Description

This adapts the configuration to make it work with RHDH 1.9+. Otherwise, the plugins installer container would fail with errors like below:

Logs 
rhdh-plugins-installer  | 
rhdh-plugins-installer  | ======= Installing dynamic plugin ./dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-marketplace
rhdh-plugins-installer  |       ==> Grabbing package archive through `npm pack`
rhdh-plugins-installer  | Traceback (most recent call last):
rhdh-plugins-installer  |   File "/opt/app-root/src/install-dynamic-plugins.py", line 162, in run_command
rhdh-plugins-installer  |     return subprocess.run(
rhdh-plugins-installer  |            ^^^^^^^^^^^^^^^
rhdh-plugins-installer  |   File "/usr/lib64/python3.11/subprocess.py", line 571, in run
rhdh-plugins-installer  |     raise CalledProcessError(retcode, process.args,
rhdh-plugins-installer  | subprocess.CalledProcessError: Command '['npm', 'pack', '/opt/app-root/src/dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-marketplace']' returned non-zero exit status 254.
rhdh-plugins-installer  | 
rhdh-plugins-installer  | During handling of the above exception, another exception occurred:
rhdh-plugins-installer  | 
rhdh-plugins-installer  | Traceback (most recent call last):
rhdh-plugins-installer  |   File "/opt/app-root/src/install-dynamic-plugins.py", line 1284, in <module>
rhdh-plugins-installer  |     main()
rhdh-plugins-installer  |   File "/opt/app-root/src/install-dynamic-plugins.py", line 1269, in main
rhdh-plugins-installer  |     _, plugin_config = install_plugin(plugin, plugin_path_by_hash, dynamic_plugins_root, skip_integrity_check)
rhdh-plugins-installer  |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
rhdh-plugins-installer  |   File "/opt/app-root/src/install-dynamic-plugins.py", line 917, in install_plugin
rhdh-plugins-installer  |     plugin_path = installer.install(plugin, plugin_path_by_hash)
rhdh-plugins-installer  |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
rhdh-plugins-installer  |   File "/opt/app-root/src/install-dynamic-plugins.py", line 814, in install
rhdh-plugins-installer  |     result = run_command(
rhdh-plugins-installer  |              ^^^^^^^^^^^^
rhdh-plugins-installer  |   File "/opt/app-root/src/install-dynamic-plugins.py", line 179, in run_command
rhdh-plugins-installer  |     raise InstallException(msg)
rhdh-plugins-installer  | InstallException: Error while installing plugin /opt/app-root/src/dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-marketplace with 'npm pack': command failed with exit code 254
rhdh-plugins-installer  | command: npm pack /opt/app-root/src/dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-marketplace
rhdh-plugins-installer  | stderr: npm error code ENOENT
rhdh-plugins-installer  | npm error syscall open
rhdh-plugins-installer  | npm error path /opt/app-root/src/dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-marketplace/package.json
rhdh-plugins-installer  | npm error errno -2
rhdh-plugins-installer  | npm error enoent Could not read package.json: Error: ENOENT: no such file or directory, open '/opt/app-root/src/dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-marketplace/package.json'
rhdh-plugins-installer  | npm error enoent This is related to npm not being able to find a file.
rhdh-plugins-installer  | npm error enoent
rhdh-plugins-installer  | npm error A complete log of this run can be found in: /opt/app-root/src/.npm/_logs/2026-02-11T15_15_26_304Z-debug-0.log
rhdh-plugins-installer  | 
rhdh-plugins-installer  | ======= Cleaning up temporary catalog index directory
rhdh-plugins-installer  | ======= Removed lock file: /dynamic-plugins-root/install-dynamic-plugins.lock
Container rhdh-plugins-installer Error service "install-dynamic-plugins" didn't complete successfully: exit 1
service "install-dynamic-plugins" didn't complete successfully: exit 1
Error: executing /usr/libexec/docker/cli-plugins/docker-compose -f compose.yaml up --force-recreate: exit status 1

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests updated and passing
  • Documentation updated
  • Built-in TechDocs updated if needed. Note that TechDocs changes may need to be reviewed by a Product Manager and/or Architect to ensure content accuracy, clarity, and alignment with user needs.

How to test changes / Special notes to the reviewer

Running podman|docker compose up with the next RHDH image tag should work as expected:

image

@rhdh-qodo-merge
Copy link
Contributor

rhdh-qodo-merge bot commented Feb 11, 2026 •
edited
Loading

PR Reviewer Guide 🔍

(Review updated until commit ba1ab4a)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

SELinux Mount

The bind mount for ./configs changed from :Z to :z (in multiple services). :z shares the SELinux label across containers, while :Z makes it private; verify this is intentional and that it fixes the startup issue without introducing cross-container access problems or breaking setups that rely on the previous labeling behavior.

 
rhdh:
  container_name: rhdh
  image: ${RHDH_IMAGE:-quay.io/rhdh-community/rhdh:next-1.9}
  env_file:
    - path: "./default.env"
      required: true
    - path: "./.env"
      required: false
  user: "1001"
  entrypoint:
    - "/opt/app-root/src/wait-for-plugins-and-start.sh"
  ports: # dclint disable-line no-unbound-port-interfaces
    - "7007:7007"
    - "127.0.0.1:9229:9229"
  environment:
    NODE_OPTIONS: "--inspect=0.0.0.0:9229 --no-node-snapshot"
  volumes:
    - ./mkdocs.yaml:/opt/app-root/src/mkdocs.yaml:Z
    - ./docs:/opt/app-root/src/docs:Z
    - ./catalog-info.yaml:/opt/app-root/src/catalog-info.yaml:Z
    - ./wait-for-plugins-and-start.sh:/opt/app-root/src/wait-for-plugins-and-start.sh:Z
    - ./configs:/opt/app-root/src/configs:z
    - dynamic-plugins-root:/opt/app-root/src/dynamic-plugins-root
    - extensions-catalog:/extensions
  depends_on:
    install-dynamic-plugins:
      condition: service_completed_successfully
    # db:
    #   condition: service_healthy

install-dynamic-plugins:
  container_name: rhdh-plugins-installer
  image: ${RHDH_IMAGE:-quay.io/rhdh-community/rhdh:next-1.9}
  # docker compose volumes are owned by root, so we need to run as root to write to them
  # the main rhdh container will be able to read from this as files are world readable
  user: "root"
  entrypoint:
    - ./prepare-and-install-dynamic-plugins.sh
  env_file:
    - path: "./default.env"
      required: true
    - path: "./.env"
      required: false
  volumes:
    - ./prepare-and-install-dynamic-plugins.sh:/opt/app-root/src/prepare-and-install-dynamic-plugins.sh:Z
    - ./local-plugins:/opt/app-root/src/local-plugins:Z
    - ./configs:/opt/app-root/src/configs:z
    - dynamic-plugins-root:/dynamic-plugins-root
Version Pinning

The orchestrator plugins were switched from pinned .tgz URLs (with integrity hashes) to OCI references using {{inherit}}. Please validate the resolved versions are deterministic (ideally pinned by tag/digest) and that required frontend wiring/config that previously lived under dynamicPlugins.frontend is not now missing or expected elsewhere.

 
includes:
  - dynamic-plugins.default.yaml

plugins:
  - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator:{{inherit}}'
    disabled: false
  - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-backend:{{inherit}}'
    disabled: false
    pluginConfig:
      orchestrator:
        dataIndexService:
          url: http://sonataflow:8899
  - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator:{{inherit}}'
    disabled: false
    pluginConfig:
      orchestrator:
        dataIndexService:
          url: http://sonataflow:8899
  - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:{{inherit}}'
    disabled: false
📚 Focus areas based on broader codebase context

Version Drift

The rhdh and install-dynamic-plugins services are pinned to quay.io/rhdh-community/rhdh:next-1.9, which may diverge from the versioning used elsewhere (e.g., :next). Validate that next-1.9 is a supported and consistently published tag, and that it stays compatible with the rest of the stack/version expectations for RHDH 1.9+. (Ref 5, Ref 6)

 
  image: ${RHDH_IMAGE:-quay.io/rhdh-community/rhdh:next-1.9}
  env_file:
    - path: "./default.env"
      required: true
    - path: "./.env"
      required: false
  user: "1001"
  entrypoint:
    - "/opt/app-root/src/wait-for-plugins-and-start.sh"
  ports: # dclint disable-line no-unbound-port-interfaces
    - "7007:7007"
    - "127.0.0.1:9229:9229"
  environment:
    NODE_OPTIONS: "--inspect=0.0.0.0:9229 --no-node-snapshot"
  volumes:
    - ./mkdocs.yaml:/opt/app-root/src/mkdocs.yaml:Z
    - ./docs:/opt/app-root/src/docs:Z
    - ./catalog-info.yaml:/opt/app-root/src/catalog-info.yaml:Z
    - ./wait-for-plugins-and-start.sh:/opt/app-root/src/wait-for-plugins-and-start.sh:Z
    - ./configs:/opt/app-root/src/configs:z
    - dynamic-plugins-root:/opt/app-root/src/dynamic-plugins-root
    - extensions-catalog:/extensions
  depends_on:
    install-dynamic-plugins:
      condition: service_completed_successfully
    # db:
    #   condition: service_healthy

install-dynamic-plugins:
  container_name: rhdh-plugins-installer
  image: ${RHDH_IMAGE:-quay.io/rhdh-community/rhdh:next-1.9}

Reference reasoning: The operator deployment references the Backstage/RHDH related image as quay.io/rhdh-community/rhdh:next, suggesting :next is the canonical moving tag used for integration. Aligning the compose image tag strategy with this pattern helps avoid unexpected incompatibilities caused by using a different tag naming scheme.

📄 References
  1. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [238-252]
  2. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [253-270]
  3. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [420-453]
  4. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [311-323]
  5. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [2913-2945]
  6. redhat-developer/rhdh-operator/config/profile/rhdh/patches/deployment-patch.yaml [1-34]
  7. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [927-934]
  8. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [431-438]

@rhdh-qodo-merge rhdh-qodo-merge bot added enhancement New feature or request Bug fix labels Feb 11, 2026
@rhdh-qodo-merge
Copy link
Contributor

rhdh-qodo-merge bot commented Feb 11, 2026 •
edited
Loading

PR Type

(Describe updated until commit a2633f6)

Bug fix, Enhancement, Documentation

Description

  • Update RHDH image to next-1.9 and adapt dynamic plugins configuration

  • Add proxy health checks and service dependencies to fix startup race conditions

  • Change volume mount attributes from :Z to :z for SELinux compatibility

  • Migrate plugin references to OCI registry format for orchestrator plugins

File Walkthrough
Relevant files
Configuration changes
compose-with-corporate-proxy.yaml
Add proxy health checks and service dependencies                 

compose-with-corporate-proxy.yaml

  • Added health check for proxy service using TCP connection test
  • Added depends_on with health condition for rhdh and
    install-dynamic-plugins services
  • Configured services to wait for proxy availability before starting
 +11/-0   
compose.yaml
Update RHDH version and fix SELinux volume mounts               

compose.yaml

  • Updated default RHDH image from 1.8 to next-1.9
  • Changed volume mount attributes from :Z to :z for configs directory
  • Applied changes to both rhdh and install-dynamic-plugins services
 +4/-4     
dynamic-plugins.override.example.yaml
Update extensions plugin configuration and naming               

configs/dynamic-plugins/dynamic-plugins.override.example.yaml

  • Renamed plugin references from marketplace to extensions
  • Simplified plugin configuration by removing detailed frontend config
  • Added OCI registry package references as commented alternatives
 +6/-23   
dynamic-plugins.yaml
Migrate to OCI packages and simplify extensions config     

configs/dynamic-plugins/dynamic-plugins.yaml

  • Added OCI registry package references for multiple plugins
  • Renamed marketplace plugin to extensions plugin
  • Removed verbose frontend plugin configuration for extensions
  • Added TODO comments for future OCI reference migration
 +14/-24 
dynamic-plugins.yaml
Migrate orchestrator plugins to OCI registry references   

orchestrator/configs/dynamic-plugins/dynamic-plugins.yaml

  • Migrated all orchestrator plugins from npm tarball URLs to OCI
    registry format
  • Removed integrity checksums as they're handled by OCI
  • Simplified plugin configuration by removing verbose frontend settings
 +7/-28   
Documentation
comparison.md
Update Extensions plugin terminology in documentation       

docs/getting-started-rhdh/comparison.md

  • Changed terminology from "marketplace" to "catalog" for Extensions
    Catalog Plugin
 +1/-1     
extensions.md
Rename marketplace to catalog in extensions docs                 

docs/getting-started-rhdh/extensions.md

  • Updated references from "Extensions marketplace" to "Extensions
    catalog"
  • Maintained consistency in plugin naming throughout documentation
 +2/-2     

@rhdh-qodo-merge
Copy link
Contributor

rhdh-qodo-merge bot commented Feb 11, 2026 •
edited
Loading

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Restore orchestration frontend config

Restore the removed pluginConfig for the orchestrator frontend plugin to ensure
it renders correctly in the UI.

orchestrator/configs/dynamic-plugins/dynamic-plugins.yaml [6-7]

 - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator:{{inherit}}'
   disabled: false
+  pluginConfig:
+    dynamicPlugins:
+      frontend:
+        red-hat-developer-hub.backstage-plugin-orchestrator:
+          appIcons:
+            - importName: OrchestratorIcon
+              name: orchestratorIcon
+          dynamicRoutes:
+            - importName: OrchestratorPage
+              menuItem:
+                icon: orchestratorIcon
+                text: Orchestrator
+              path: /orchestrator
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: The PR removes the frontend configuration for the orchestrator plugin, which will prevent it from rendering in the UI. This suggestion correctly identifies and fixes this critical functional regression.

High
General
Guard debug commands conditionally

Wrap the debugging commands pwd, id, and ls -lZ in a conditional block so they
only execute when a DEBUG flag is enabled.

wait-for-plugins-and-start.sh [25-27]

-pwd
-id
-ls -lZ
+if [ "${DEBUG:-false}" = "true" ]; then
+  pwd
+  id
+  ls -lZ
+fi
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies temporary debugging commands and proposes a robust solution to control their execution via a DEBUG flag, improving code quality and maintainability.

Low
  • Update

@rm3l rm3l force-pushed the fix/fix_startup_issue_with_rhdh_1.9 branch from af442ab to ba1ab4a Compare February 11, 2026 12:47
@rm3l
Copy link
Member Author

rm3l commented Feb 11, 2026

/review

@rhdh-qodo-merge
Copy link
Contributor

rhdh-qodo-merge bot commented Feb 11, 2026

Persistent review updated to latest commit ba1ab4a

@christoph-jerolimov christoph-jerolimov mentioned this pull request Feb 11, 2026
Closed
3 tasks
@rm3l rm3l changed the base branch from main to release-1.9 February 11, 2026 13:53
rm3l and others added 5 commits February 11, 2026 14:58
@rm3l
fix: Fix the dynamic plugins configuration to work with RHDH 1.9+
5c00712
@rm3l @christoph-jerolimov
docs: Rename the references to marketplace
6a1dc2c 
Co-authored-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@rm3l
fix: Fix mount attributes for envs with stricter SELinux policies
53ce86a
@rm3l
switch default RHDH Image to quay.io/rhdh-community/rhdh:next-1.9
c15351a 
The changes to the dynamic plugins configuration won't work otherwise in previous versions
@rm3l
chore: add quay.io and registry.access.redhat.com to NO_PROXY
2685f63 
This is needed when running the compose-corporate-proxy compose as we need to download the plugin catalog index and additional plugins from these registries
@rm3l rm3l force-pushed the fix/fix_startup_issue_with_rhdh_1.9 branch from 47b6c66 to 2685f63 Compare February 11, 2026 13:59
@rm3l
Copy link
Member Author

rm3l commented Feb 11, 2026

/cherry-pick main

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 11, 2026

@rm3l: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l rm3l changed the title fix: Fix issue with RHDH 1.9+ fix: Fix the dynamic plugins configuration to work with RHDH 1.9+ Feb 11, 2026
@rm3l rm3l changed the title fix: Fix the dynamic plugins configuration to work with RHDH 1.9+ fix: Fix the dynamic plugins configuration to work with RHDH 1.9+ [RHDHBUGS-2646] Feb 11, 2026
@rm3l rm3l marked this pull request as ready for review February 11, 2026 15:23
@rhdh-qodo-merge
Copy link
Contributor

rhdh-qodo-merge bot commented Feb 11, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Healthcheck

The new proxy healthcheck relies on bash and /dev/tcp support inside the Squid image. Please validate that the image actually contains bash (not only sh) and that /dev/tcp is enabled; otherwise the container may be marked unhealthy and block rhdh and install-dynamic-plugins startup via depends_on health conditions.

 
healthcheck:
  test: ["CMD-SHELL", "bash -c 'exec 3<>/dev/tcp/127.0.0.1/3128'"]
  interval: 5s
  timeout: 3s
  retries: 5
Volume relabel

The configs bind mount was changed from :Z to :z for both rhdh and install-dynamic-plugins. This changes SELinux relabeling semantics (private vs shared labeling). Please confirm this is intended for your runtime (Podman/Docker with SELinux) and that it won’t introduce permission issues or unintended cross-container sharing of labels.

 
- ./configs:/opt/app-root/src/configs:z
- dynamic-plugins-root:/opt/app-root/src/dynamic-plugins-root
📚 Focus areas based on broader codebase context

Possible Issue

The newly added OCI package references use the oci://...:{{inherit}} form but omit the !<plugin-id> suffix used elsewhere to identify which plugin artifact to extract from the image. Validate that RHDH 1.9+ dynamic plugin installer accepts OCI references without the ! suffix for these plugins, otherwise installs may fail or pull the wrong artifact. (Ref 5, Ref 6)

 
- package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator:{{inherit}}'
  disabled: false
- package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-backend:{{inherit}}'
  disabled: false
  pluginConfig:
    orchestrator:
      dataIndexService:
        url: http://sonataflow:8899
- package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator:{{inherit}}'
  disabled: false
  pluginConfig:
    orchestrator:
      dataIndexService:
        url: http://sonataflow:8899
- package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:{{inherit}}'
  disabled: false

Reference reasoning: The existing dynamic plugins defaults show OCI package specs that include an explicit artifact selector using !<plugin-name>, alongside local ./dynamic-plugins/dist/... fallbacks. This suggests the ! suffix is part of the expected OCI spec for dynamic plugin images and should be preserved unless the installer has changed to infer the plugin automatically.

📄 References
  1. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [5-13]
  2. redhat-developer/rhdh-operator/examples/rhdh-cr.yaml [45-68]
  3. redhat-developer/rhdh-operator/pkg/model/testdata/rhdh-deployment.yaml [36-58]
  4. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [354-360]
  5. redhat-developer/rhdh/dynamic-plugins.default.yaml [481-487]
  6. redhat-developer/rhdh/dynamic-plugins.default.yaml [957-969]
  7. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [14-28]
  8. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [122-142]

@rm3l
Copy link
Member Author

rm3l commented Feb 11, 2026

/cc @christoph-jerolimov

@rhdh-qodo-merge rhdh-qodo-merge bot added the documentation Improvements or additions to documentation label Feb 11, 2026
@rhdh-qodo-merge
Copy link
Contributor

rhdh-qodo-merge bot commented Feb 11, 2026 •
edited
Loading

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Enable the Quay backend plugin

Uncomment the Quay backend plugin configuration, as it is required for the
corresponding frontend plugin to function correctly.

configs/dynamic-plugins/dynamic-plugins.yaml [14-18]

 # Quay plugin
-# - package: 'oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-quay-backend:{{inherit}}'
-#   disabled: false
+- package: 'oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-quay-backend:{{inherit}}'
+  disabled: false
 - package: 'oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-quay:{{inherit}}'
   disabled: false
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies that the Quay frontend plugin is enabled without its required backend, which would lead to a non-functional component. Enabling the backend is crucial for the plugin's correctness.

Medium
General
Simplify healthcheck syntax

Simplify the healthcheck command by using the CMD form instead of CMD-SHELL to
avoid nested shells and improve readability.

compose-with-corporate-proxy.yaml [25-29]

 healthcheck:
-  test: ["CMD-SHELL", "bash -c 'exec 3<>/dev/tcp/127.0.0.1/3128'"]
+  test: ["CMD", "bash", "-c", "exec 3<>/dev/tcp/127.0.0.1/3128"]
   interval: 5s
   timeout: 3s
   retries: 5
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion improves the healthcheck syntax by changing from CMD-SHELL to CMD and splitting the command, which is a best practice that enhances clarity and avoids potential shell-related issues.

Low
  • More

nickboldt
nickboldt reviewed Feb 12, 2026
View reviewed changes
nickboldt
nickboldt reviewed Feb 12, 2026
View reviewed changes
nickboldt
nickboldt reviewed Feb 12, 2026
View reviewed changes
nickboldt
nickboldt reviewed Feb 12, 2026
View reviewed changes
compose.yaml
rhdh:
container_name: rhdh
image: ${RHDH_IMAGE:-quay.io/rhdh-community/rhdh:1.8}
image: ${RHDH_IMAGE:-quay.io/rhdh-community/rhdh:next-1.9}
Copy link
Member

@nickboldt nickboldt Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also happen automatically when we branch for 1.10, per updates in RHDHBUGS-2323

Copy link
Member

@nickboldt nickboldt Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, new script seems to be working for branch creation #162

@rm3l rm3l force-pushed the fix/fix_startup_issue_with_rhdh_1.9 branch from a7054fc to 7337874 Compare February 13, 2026 09:43
@rm3l rm3l requested a review from nickboldt February 13, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@subhashkhileri subhashkhileri Awaiting requested review from subhashkhileri

@zdrapela zdrapela Awaiting requested review from zdrapela

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@nickboldt nickboldt Awaiting requested review from nickboldt

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Bug fix documentation Improvements or additions to documentation enhancement New feature or request Possible security concern Review effort 2/5 Review effort 3/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rm3l @openshift-cherrypick-robot @nickboldt