Skip to content

chore: add install-dynamic-plugins workspace to CODEOWNERS#3365

Merged
gustavolira merged 3 commits into
redhat-developer:mainfrom
gustavolira:chore/codeowners-install-dynamic-plugins
Jun 22, 2026
Merged

chore: add install-dynamic-plugins workspace to CODEOWNERS#3365
gustavolira merged 3 commits into
redhat-developer:mainfrom
gustavolira:chore/codeowners-install-dynamic-plugins

Conversation

@gustavolira

@gustavolira gustavolira commented Jun 10, 2026

Copy link
Copy Markdown
Member

Description

Registers code ownership for the new workspaces/install-dynamic-plugins workspace in .github/CODEOWNERS, following the existing convention (entry inserted in alphabetical order):

/workspaces/install-dynamic-plugins                 @redhat-developer/rhdh-plugins-maintainers @redhat-developer/rhdh-plugins

The rhdh-plugins team owns the workspace, alongside the repo-wide rhdh-plugins-maintainers team that every workspace entry includes.

@gustavolira gustavolira requested review from a team as code owners June 10, 2026 22:08
@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Jun 10, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@rhdh-gh-app

rhdh-gh-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

⚠️ CODEOWNERS Validation Failed

The following users are listed in CODEOWNERS but are not members of the rhdh-plugins-codeowners team:

rrbanda

An org admin needs to add the missing members to the team before this PR can be merged.

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Add CODEOWNERS entry for install-dynamic-plugins workspace
⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

Walkthroughs

Description
• Register ownership for the new workspaces/install-dynamic-plugins workspace in CODEOWNERS.
• Follow existing convention by inserting the entry in alphabetical order.
High-Level Assessment

The following are alternative approaches to this PR:

1. Add a wildcard CODEOWNERS rule for all workspaces
  • ➕ Less maintenance when adding new workspaces
  • ➕ Guarantees baseline ownership coverage for any new workspace directory
  • ➖ Reduces per-workspace ownership specificity
  • ➖ May unintentionally assign owners to workspaces that need different teams or additional reviewers

Recommendation: Keep the explicit per-workspace CODEOWNERS entry as implemented; it matches existing repo convention and preserves fine-grained ownership. Consider a wildcard only if maintenance overhead becomes a recurring problem.

Grey Divider

File Changes

Other (1)
CODEOWNERS Assign code owners for /workspaces/install-dynamic-plugins +1/-0

Assign code owners for /workspaces/install-dynamic-plugins

• Adds a CODEOWNERS rule for the new 'workspaces/install-dynamic-plugins' workspace. The entry is placed in alphabetical order to match existing conventions.

.github/CODEOWNERS


Grey Divider

Qodo Logo

@rhdh-gh-app

rhdh-gh-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

⚠️ CODEOWNERS Validation Failed

The following users are listed in CODEOWNERS but are not members of the rhdh-plugins-codeowners team:

rrbanda

An org admin needs to add the missing members to the team before this PR can be merged.

gustavolira and others added 3 commits June 22, 2026 10:58
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replaces @redhat-developer/rhdh-install with @redhat-developer/rhdh-plugins
on the /workspaces/install-dynamic-plugins entry.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@gustavolira gustavolira force-pushed the chore/codeowners-install-dynamic-plugins branch from 336faa8 to 64253a7 Compare June 22, 2026 13:58
@gustavolira gustavolira merged commit 2903d71 into redhat-developer:main Jun 22, 2026
12 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants