Skip to content

fix(#3482): resolve SonarQube MINOR issues in homepage workspace #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

fix(#3482): resolve SonarQube MINOR issues in homepage workspace #3498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...homepage/plugins/dynamic-home-page/src/components/OnboardingSection/OnboardingSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ export function useOnboardingSection() {
return name;
};

const greetingLine = !profileLoading ? (
const greetingLine = profileLoading ? null : (
<Typography variant="h3" sx={sectionTitleSx}>
{`${greeting}, ${profileDisplayName() || t('onboarding.guest')}!`}
</Typography>
) : null;
);

const body = (
<Box sx={{ mt: 2 }}>
Expand Down
4 changes: 3 additions & 1 deletion workspaces/homepage/plugins/dynamic-home-page/src/utils/useHomePageCardTitle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ export function useHomePageCardTitle(
t,
props.titleKey ?? defaultTitleKey,
props.title,
) ?? t(defaultTitleKey as keyof typeof t)
) ??
getTranslatedTextWithFallback(t, defaultTitleKey, undefined) ??
defaultTitleKey
);
}
Loading