Conversation
HusneShabbir
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
September 2, 2026 18:16
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4551 +/- ##
=======================================
Coverage 62.26% 62.26%
=======================================
Files 2606 2606
Lines 104644 104644
Branches 29428 29416 -12
=======================================
+ Hits 65155 65157 +2
+ Misses 38927 38925 -2
Partials 562 562
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…erage Extend Playwright coverage for inline rename POMs, upload modal UX, card counts, overwrite flow, and compact overlay/docked modes with scoped dialog locators that work in nested MUI panels. Co-authored-by: Cursor <cursoragent@cursor.com>
HusneShabbir
force-pushed
the
feat/notebooks-release-2.1-e2e-coverage
branch
from
September 4, 2026 11:57
a93bf1d to
c21f9ee
Compare
jrichter1
reviewed
Sep 4, 2026
Use getByRole with exact name matching instead of invalid locator options, and replace manual aria-label checks with Playwright auto-retry assertions. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Addressed review feedback in 5dfb848:
Verified locally: 53/53 notebook specs pass ( |
Compact scoped dialogs scroll inside the paper, so the footer Cancel button can sit below the fold and never match getByRole visibility checks. Fall back to the always-visible title close control when dismissing the upload modal in overlay/docked notebook modes. Assisted-by: Auto Co-authored-by: Cursor <cursoragent@cursor.com>
Compact overlay/docked modes nest the upload and delete-document dialogs inside the chatbot dialog, so footer buttons are absent from the accessibility tree and getByRole never matches. Scope footer actions via MuiDialogActions and button:text-is(), and target the dropzone via role=button aria-label instead. Assisted-by: Auto Co-authored-by: Cursor <cursoragent@cursor.com>
|
jrichter1
approved these changes
Sep 7, 2026
rohitkrai03
pushed a commit
to rohitkrai03/rhdh-plugins
that referenced
this pull request
Sep 10, 2026
…redhat-developer#4551) * test(intelligent-assistant): add focused notebook Release 2.1 E2E coverage Extend Playwright coverage for inline rename POMs, upload modal UX, card counts, overwrite flow, and compact overlay/docked modes with scoped dialog locators that work in nested MUI panels. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(intelligent-assistant): address notebook E2E POM review feedback Use getByRole with exact name matching instead of invalid locator options, and replace manual aria-label checks with Playwright auto-retry assertions. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(intelligent-assistant): dismiss compact upload modal via title close Compact scoped dialogs scroll inside the paper, so the footer Cancel button can sit below the fold and never match getByRole visibility checks. Fall back to the always-visible title close control when dismissing the upload modal in overlay/docked notebook modes. Assisted-by: Auto Co-authored-by: Cursor <cursoragent@cursor.com> * fix(intelligent-assistant): use DOM locators for nested notebook modals Compact overlay/docked modes nest the upload and delete-document dialogs inside the chatbot dialog, so footer buttons are absent from the accessibility tree and getByRole never matches. Scope footer actions via MuiDialogActions and button:text-is(), and target the dropzone via role=button aria-label instead. Assisted-by: Auto Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: HusneShabbir <husneshabbir447@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotebookSurfacePageandNotebookAddDocumentModalPagewith compact header actions, scoped MUI dialog locators (hasText/aria-labelfor nested panels), and sidebar expand helpers.lightspeed.notebooks-compact.test.tsto use page objects; adds upload-complete, remove-resource modal, and delete-notebook modal panel tests.Resolves:https://redhat.atlassian.net/browse/RHIDP-15135
Test plan
yarn playwright test e2e-tests/lightspeed.notebooks.test.ts --project=en --workers=1(23 passed)yarn playwright test e2e-tests/lightspeed.notebooks-compact.test.ts --project=en --workers=1(30 passed)yarn playwright test e2e-tests/lightspeed.notebooks.conversation.test.ts --project=en