test(intelligent-assistant-backend): add RBAC permission integration tests - #4693
Conversation
…tests Follow-up to redhat-developer#4612 — lock in consolidated permission names on backend routes with authorize() contract tests, selective allow/deny coverage, permission metadata registration, and a missing 403 for notebook-conversation-ids. Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4693 +/- ##
=======================================
Coverage 62.60% 62.60%
=======================================
Files 2635 2635
Lines 105191 105191
Branches 29501 29514 +13
=======================================
Hits 65859 65859
Misses 37478 37478
Partials 1854 1854
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 7:47 PM UTC · Completed 7:52 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $1.13 |
Review — approveSummaryTest-only PR adding RBAC permission integration tests for the What was checkedCorrectness
Security
Intent & coherence
Style & conventions
Documentation currency
Findings[low · style] Inconsistent Verdict✅ Approve — well-structured, correctly-wired integration tests that directly verify the RBAC permission contracts introduced in #4612. The single low-severity finding is cosmetic and non-blocking. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
4 participants
Summary
Follow-up integration test coverage for #4612 (consolidated IA RBAC permissions).
rbacPermissions.test.tswith permission name contract tests for all four feature-linked sets (chat,notebooks,mcp.tools,skills)iaPermissionsGET /notebook-conversation-idsPOST /v1/sessionsFixes RHIDP-15748(test gap from #4612)
Test plan
yarn test src/service/rbacPermissions.test.ts— 9/9 passyarn test src/service/router.test.ts -t "notebook-conversation-ids"— 3/3 passyarn test src/service/notebooks/notebooksRouter.test.ts -t "RBAC"— 1/1 pass