Adding no gerunds in titles Suggestion rule#1008
Open
aireilly wants to merge 2 commits into
Open
Conversation
|
⚡️ Deploying PR Preview... |
babcdf9 to
7eaed84
Compare
jeana-redhat
reviewed
Feb 4, 2026
Contributor
jeana-redhat
left a comment
There was a problem hiding this comment.
Oops I thought I hit submit on my comment but I guess it started a review
Member
Author
|
lol forgot about this but I guess we can push the button now? |
Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
9c465e4 to
c4b7230
Compare
Add exceptions list for non-gerund words ending in -ing (String, Spring, Existing, Underlying, etc.) that were incorrectly flagged. Rewrite the Tengo suggestion script with a lookup table for doubled-consonant verbs (Running→Run not Runn) and silent-e verbs (Writing→Write not Writ), plus three new safe suffix patterns (-ving→-ve, -cing→-ce, -ling→-le). Expand test fixtures from 13 to 42 invalid and 14 to 31 valid headings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red Hat docs guidance is now not to use gerunds in titles, in favor of the imperative form.
This suggestion rule uses a tengo script replace action to suggest a correct replacement.