Demoting crash from error to sugg#320
Merged
rolfedh merged 1 commit intoSep 30, 2022
Merged
Conversation
|
🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-320.surge.sh 🎊 |
|
Click here to review and test in web IDE: |
rolfedh
approved these changes
Sep 30, 2022
rolfedh
left a comment
rolfedh
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Ready to merge?
Member
Author
|
Yes please @rolfedh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently list crash as an error term. This is incorrect. Crash in the verb form is incorrect, however, crash as a noun is acceptable in various usages.
https://redhat-documentation.github.io/supplementary-style-guide/#crash
Demoting to Suggestion should fix for now. Ideally, we should catch with POS tagging only when crash is used as a verb. POS checking not possible with Vale rules - yet: vale-cli/vale-vscode#60