Fix: Read surface properties from nested surface_properties dict#222
Open
shaunmorris wants to merge 1 commit intoredruin1:mainfrom
Open
Fix: Read surface properties from nested surface_properties dict#222shaunmorris wants to merge 1 commit intoredruin1:mainfrom
shaunmorris wants to merge 1 commit intoredruin1:mainfrom
Conversation
The get_surface_properties function was incorrectly reading properties
(solar-power, magnetic-field, pressure, gravity) directly from the surface
object. Now correctly reads from surface.get('surface_properties', {}) to
match the actual data structure.
Added a test in data/planets.py to verify that Fulgora's data is now
different that Nauvis'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_surface_properties function was incorrectly reading properties (solar-power, magnetic-field, pressure, gravity) directly from the surface object. Now correctly reads from surface.get('surface_properties', {}) to match the actual data structure.
Added a test in data/planets.py to verify that Fulgora's data is now different that Nauvis'.