Repository navigation
A bone named on a multi-root entity resolves to the part it sits on - #544
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of reeleehq/cutan#104 (P3 of #497). In a joint or a verb,
ned@hand_r(entity, a bone a part is drawn on) now resolves to that part when the entity has more than one root part; before, it was refused ("has 3 root parts; name the part"), so a character whose rig gains hand bones (cutan#104) could no longer saygrasp by: ned@hand_ras the hold verbs promised (#535). One root, and a slotless bone (a prop'sgrip), resolve exactly as before. Test in tests/test_solve.py; doctest on_bone_carrier.