Repository navigation
Easing: take the CSS curves from an's shared easing contract (#23) - #29
Merged
Merged
Conversation
The TypeScript port reads its named curves from @thorwhalen/an-contract (easing.json: css_hyphenated_curves plus the CSS 'ease' import alias), inlined at build time so the published package has no runtime JSON import. Tests in both languages assert burns' easings against the contract's sample values (agreement to a few 1e-12: the contract's solver stops at 1e-12). The Python table stays in burns (no dependency on an) and is pinned to the contract by the test. Golden vectors unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
burns' named easings are now the CSS entries of
an's shared easing contract (an ADR 0006: consumers install the published package rather than copy files).ts/):CSS_BEZIERSis built from@thorwhalen/an-contract'seasing.json:css_hyphenated_curves(ease-in,ease-out,ease-in-out) pluscss_import_aliases(CSSease), withlinearas before. The package is a devDependency and tsup inlines it (noExternal), so the publishedkenburnzcarries just the two tables and no runtime JSON import.test/an-contract.test.tsasserts the curves and every sample value oflinearand the three CSS entries.an, so the table stays inburns/easing.pyandtests/test_an_contract.pypins it, and its values, to the contract, found in an installedanor ints/node_modules; it skips when neither is present (the Python CI job). The golden vectors tie Python to TypeScript, which checks the contract on every CI run.step-start/step-end(a stepped crop makes no Ken Burns move) and an's legacy and Manim curves (burns'easestays CSSease, exactly the contract's import alias).Tests: Python 258 passed; TS typecheck clean, vitest 144 passed, build OK.
Review: small, low-stakes change (no auth, secrets, deploy, infra or data deletion), so no adversarial review, per the 2026-10-14 policy.
🤖 Generated with Claude Code