Skip to content

Refresh stale RowKey comment in artifact_store (#64, #65) #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thorwhalen merged 1 commit into from
Oct 14, 2026
Merged

Refresh stale RowKey comment in artifact_store (#64, #65) #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lacing/artifact_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,8 +739,10 @@ def content_hash_of(record: BaseModel) -> str | None:
)

def _key_of_id(row_or_key):
# ``wrap_kvs`` hands this the key dict on writes and the ORM row on
# iteration (sqldol's ``__iter__`` yields rows, not keys).
# ``wrap_kvs`` hands this a key dict on writes and a ``RowKey`` on
# iteration (sqldol's ``__iter__`` yields ``RowKey``s, which are
# dicts that also read as attributes). The attribute branch is only
# for older sqldol releases that iterated ORM rows.
if isinstance(row_or_key, dict):
return row_or_key["artifact_id"]
return row_or_key.artifact_id
Expand Down
Loading