Repository navigation
Fix TIME_VARYING probe blind spot to positional clock-readers - #22
Merged
Merged
Conversation
classify()'s time probe ran a spatially uniform still (color=c=gray), so a purely positional clock-reader like motion.ffmpeg.crop produced zero luma diff and fell through to CONTENT_ADAPTIVE instead. Swap the still for rgbtestsrc: deterministic, frame-to-frame invariant, and spatially non-uniform, so a moving crop window now registers a real time_delta and classifies correctly. Closes #20 Claude-Session: https://claude.ai/code/session_01PoBJX7ZWjC52NTVN59K7Mf
TestTheStillProbeCannotSeeAMovingCropWindow now asserts the opposite of its own name since the still switched to rgbtestsrc. Closes #20 Claude-Session: https://claude.ai/code/session_01PoBJX7ZWjC52NTVN59K7Mf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frame_dependency.classify's TIME_VARYING probe ran a spatially UNIFORM still (color=c=gray), so a purely positional clock-reader likemotion.ffmpeg.cropproducedtime_delta == 0.0and fell through to a misclassifiedCONTENT_ADAPTIVEverdict.rgbtestsrc: deterministic (noseed), frame-to-frame invariant (measured bit-identical), and spatially non-uniform, so a moving crop window now registers a nonzerotime_delta.looks/tests/test_time_varying.py'sTestTheStillProbeCannotSeeAMovingCropWindowflipped from documenting the wrong verdict to asserting the correct one;motion.ffmpeg.cropis no longer excluded fromTestDeclarationAgreesWithMeasurement's sweep. Removed the now-closed blind-spot entry fromframe_dependency's "What this does not answer" docstring section.Closes #20
Test plan
pytest -q --doctest-modules looks— 1356 passed, 3 skipped, on Homebrew ffmpeg 9.0.1ffmpeg@6(6.1.6, CI-matching) — 1356 passed, 3 skippedruff check/ruff format --checkcleanhttps://claude.ai/code/session_01PoBJX7ZWjC52NTVN59K7Mf