Repository navigation
Move media backends into one 'media' extra; base keeps the pure modules (#54) - #56
Merged
Merged
Conversation
…modules (#54) moviepy, opencv-contrib-python, scipy, pydub, burns, numpy, pillow and looks move from the base dependencies to the 'media' extra. mixing.audio and mixing.video raise an ImportError naming "pip install 'mixing[media]'" when the extra is missing. No public name is removed or renamed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54. Under the commitment on reeleehq/reelee#541.
What changes
pip install mixing) now declares onlyconfig2py,dol,xdol. The pure modules (srt,chapters,errors,util,egress,transcript, dubbing TTS/SRT) import and work with no media backend.media:moviepy,opencv-contrib-python,scipy,pydub,burns, plusnumpy,pillowandlooks, which only the media modules import. Thetestinganddevextras includemixing[media], so CI still runs the whole suite.mixing.audioandmixing.video(and facade names resolving to them, e.g.mixing.Video,dub_video_from_srt) raiseImportError: ... requires the 'media' extra (missing: ...). Install it with pip install 'mixing[media]'.The check isutil.require_media_extra, run at the top of both package__init__s viafind_spec, so nothing heavy is imported to decide.util.require_packagealso names the extra for media libs imported lazily (e.g.scipy.signal)..claude/CLAUDE.md, themixingskill) updated.Tests
New
mixing/tests/test_guard_base_install.pyruns a fresh interpreter with the media libs hidden (sys.modules[name] = None): the pure modules import and load none of them; each media entry point raises theImportErrornamingmixing[media]; the pyproject split is pinned. Full suite green locally with the extra installed.In-fleet dependents
Found by
rgoverpyproject.toml/setup.cfgunder the projects tree. One-line PRs change the dependency tomixing[media]; on a mixing without the extra pip only warns, so they can land before or after this release.mixing.audio,mixing.video)assemble_audio_track,replace_audio,concatenate_videos)mixing.video)mixing.audio)reeleeandsynthextras,mixing.audio)mixing.video.thumbnail)mixingdependency declaredFor syll-songs: a pinned
mixing==0.0.55is unaffected. An unpinned fresh install needsmixing[media].Deploy: merging releases to PyPI. Anything that installs mixing unpinned in a fresh environment (reelee-iq deploy, syll-songs rebuilds) must carry
mixing[media], or have the dependent PRs above merged first.Review: small packaging change, tests only (per the review policy).
🤖 Generated with Claude Code