Skip to content

requirements: imported module counts as present; EJS message names the interpreter - #50

Merged
thorwhalen merged 2 commits into
mainfrom
ejs-warning-diagnostics-46
Oct 27, 2026
Merged

thorwhalen merged 2 commits into
mainfrom
ejs-warning-diagnostics-46

Conversation

@thorwhalen

Copy link
Copy Markdown
Collaborator

Refs #46 (does not close it: the warning could not be reproduced; the issue stays open for the reporter's environment).

  • has_module: when find_spec raises (an imported module with __spec__ = None), a module present in sys.modules counts as present instead of "missing". Hypothesis fix.
  • The yt-dlp-ejs message now names the interpreter it looked in, so the next occurrence is diagnosable (yt-dlp running from another interpreter, or scripts supplied via remote_components, are the likelier causes).

Adversarial review (Opus): safe to merge; hypothesis only weakly plausible (so the issue stays open); cannot hide a real missing-module warning (a None sys.modules entry still reads as missing); tests meaningful. Applied the two nits (message punctuation, docstring accuracy).

thorwhalen and others added 2 commits October 27, 2026 01:21
…ses; EJS message names the interpreter (#46)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@thorwhalen
thorwhalen merged commit 3a8a8a3 into main Oct 27, 2026
12 checks passed
@thorwhalen
thorwhalen deleted the ejs-warning-diagnostics-46 branch October 27, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant