Repository navigation
Playlist flat rows and SearchHit share one entry rule - #51
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…review) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47 (non-breaking scope).
search_youtubehits andyoutube_playlist_info(flat=True)rows now read a flat yt-dlp entry through one rule (_entry_url: the entry's ownurl, elsewebpage_url); the search hit adds a watch-URL fallback, the playlist row keepsNone(playlists may come from non-YouTube extractors). Public return types are unchanged, so no caller breaks. Not done: makingyoutube_playlist_inforeturnSearchHit(a public return-type break): if wanted, it can be a dict-compatibleSearchHitin a later minor release.Adversarial review (Opus): OK to land. Its one real finding (the first version synthesised a YouTube watch URL for playlist rows without a URL, wrong for other sites) is fixed: playlist rows never invent a URL, and a test pins it. Also noted: a no-id search hit now has
url=""instead ofwatch?v=.