Conversation
Owner
|
ACK d3899dc Amazing job! Merging now, but also this makes me think since we implemented this in BDK iOS and Monday, it may be a good candidate to add to BitcoinUI as a reusable function. No big rush, but I'm adding an Issue so in the future me or someone else can add it there (and then since we already import BitcoinUI in BDK iOS and Monday we can get that functionality for free from BitcoinUI and then remove the code from the client apps) |
Owner
|
Bitcoin UI issue I just added reez/BitcoinUI#109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR added ₿-only format on balance screen view and resolve the issue
Reference
https://bitcoin.design/guide/designing-products/units-and-symbols/#sample-mockups
Screens
Checklists
All Submissions:
.swift-formatfileNew Features:
I've added docs for the new feature