fix: parameterize settings shortcut in footer for cross-platform display#976
Open
Urielbp wants to merge 31 commits into
Open
fix: parameterize settings shortcut in footer for cross-platform display#976Urielbp wants to merge 31 commits into
Urielbp wants to merge 31 commits into
Conversation
Replaces the hardcoded ⌘, symbol in the settings footer shortcut hint
with a dynamic {shortcut} placeholder resolved via formatShortcutDisplay,
so Windows and Linux users see Ctrl+, instead of the macOS-only ⌘ glyph.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Just tested on macOS and it's working as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
⌘,directly in every locale string, which is macOS-only and displays incorrectly on Windows (Ctrl+,) and Linux{shortcut}placeholder in all 18 locale filesSettingsFooter.tsxnow resolves the shortcut at render time via the existingformatShortcutDisplayutility, so each platform sees its native shortcut representationChanges
src/components/SettingsFooter.tsx— importformatShortcutDisplay, computeSETTINGS_SHORTCUTonce at module level, pass it as theshortcutinterpolation param tot('settings.footerShortcut', ...)src/lib/locales/*.json(18 files) — replace hardcoded⌘,with{shortcut}placeholderBefore (Linux)
After (Linux)
Testing
tscerrors introduced)