Add WotLK 3.3.5 support, detect game version from exe#51
Merged
Conversation
Auto-detect the installed expansion by reading VS_FIXEDFILEINFO from WoW.exe or Ascension.exe in the game directory. Filter TOC files per expansion: vanilla <= 11200 (unchanged), wotlk 30000..30300. New --game-version flag overrides autodetect for clients without readable PE version info. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 5 +1
Lines 487 551 +64
Branches 82 88 +6
=========================================
+ Hits 487 551 +64 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-detect the installed expansion by reading VS_FIXEDFILEINFO from WoW.exe or Ascension.exe in the game directory. Filter TOC files per expansion: vanilla <= 11200 (unchanged), wotlk 30000..30300. New --game-version flag overrides autodetect for clients without readable PE version info.