Skip to content
This repository was archived by the owner on Apr 28, 2026. It is now read-only.

ENG-8857: Remove hobby tier - #1755

Merged
Kastier1 merged 1 commit into
mainfrom
carlos/remove-free-tier
Feb 19, 2026
Merged

Kastier1 merged 1 commit into
mainfrom
carlos/remove-free-tier

Conversation

@carlosabadia

Copy link
Copy Markdown
Collaborator

No description provided.

@linear

linear Bot commented Feb 18, 2026

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the hardcoded show_free_tier parameter from pricing_table() and replaces it with dynamic state-driven visibility using EnableTiersState.enable_free_tier and EnableTiersState.enable_pro_tier. The change makes the pricing table properly handle all four combinations of free/pro tier visibility (both on, only pro, only free, neither) instead of the previous two-case logic that always showed the free column when pro was enabled.

  • Removed show_free_tier parameter from pricing_table() signature and its usage in reflex_build_table()
  • Refactored feature row rendering to use nested rx.cond for all four tier visibility combinations
  • Made the Hobby column in sticky_pricing_header() conditionally rendered based on EnableTiersState.enable_free_tier
  • Updated grid column count logic to dynamically calculate columns (2, 3, or 4) based on which tiers are enabled
  • Adjusted sticky header top offset from 121px to 111px when banner is visible

Confidence Score: 4/5

  • This PR is safe to merge — it's a straightforward UI logic refactor with no data or API changes.
  • The changes are purely in the presentation layer, replacing a hardcoded parameter with state-driven conditional rendering. The nested rx.cond logic is correct for all 4 tier combinations. The only minor concern is the hardcoded CSS offset change (121px to 111px) which may need visual verification.
  • No files require special attention beyond visual QA of pcweb/pages/pricing/table.py to verify sticky header positioning.

Important Files Changed

Filename Overview
pcweb/pages/pricing/table.py Refactored tier visibility logic to properly handle all 4 combinations of free/pro tiers. Removed show_free_tier parameter in favor of EnableTiersState.enable_free_tier. Grid column count and feature rows now dynamically adjust. Minor CSS offset change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[pricing_table called] --> B{is_simple_table?}
    B -->|Yes| C[Render 2-col: name + free]
    B -->|No| D{enable_pro_tier AND enable_free_tier?}
    D -->|Yes| E[4 cols: name, free, pro, enterprise]
    D -->|No| F{enable_pro_tier only?}
    F -->|Yes| G[3 cols: name, pro, enterprise]
    F -->|No| H{enable_free_tier only?}
    H -->|Yes| I[3 cols: name, free, enterprise]
    H -->|No| J[2 cols: name, enterprise]

    K[sticky_pricing_header] --> L{pro AND free?}
    L -->|Yes| M[grid-cols-4]
    L -->|No| N{pro OR free?}
    N -->|Yes| O[grid-cols-3]
    N -->|No| P[grid-cols-2]
Loading

Last reviewed commit: 5caad49

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Kastier1
Kastier1 merged commit f22aaa1 into main Feb 19, 2026
10 checks passed
@Kastier1
Kastier1 deleted the carlos/remove-free-tier branch February 19, 2026 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants