tentative migrate pyright to ty by benedikt-bartscher · Pull Request #6465 · reflex-dev/reflex

benedikt-bartscher · 2026-05-06T19:22:48Z

time ty check
...
ty check  6.93s user 0.22s system 1415% cpu 0.505 total

time pyright
...
pyright  23.59s user 0.74s system 168% cpu 14.470 total

codspeed · 2026-05-06T19:26:52Z

Merging this PR will not alter performance

1 warning

⚠️ 10 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 148 untouched benchmarks

_{Comparing benedikt-bartscher:migrate-pyright-to-ty (bbd2deb) with main (eb0cd67)}

Resolve conflicts from upstream's memo refactor (reflex-dev#6517, promote rx._x.memo to rx.memo): memo implementation moved to reflex_base.components.memo and CustomComponent was removed. Re-apply the ty migration changes onto the new locations: - reflex/experimental/memo.py: take upstream's deprecated alias - reflex_base/components/memo.py: type fn params as FunctionType and add ty:ignore for dynamic __signature__ assignment - tests: drop CustomComponent tests removed upstream; carry ty:ignore comments onto the relocated memo/telemetry tests - pyproject.toml / uv.lock: keep both towncrier (upstream) and ty (HEAD) - pyi_hashes.json: regenerated ty check, ruff, and the unit suite pass.

Conflict resolutions of note: - pyproject.toml: `[tool.pyright]` is replaced by the branch's `[tool.ty.*]` tables; main's new `packages/reflex-ui-shared` exclusion is folded in, and `[tool.check-outdated-deps] backend_pinned` now pins `ty` instead of `pyright`, which is what main's new `scripts/check_outdated_deps.py` reads (the branch's inline `grep -vE` filter in the workflow is gone). - .pre-commit-config.yaml: the repo-wide hook runs `ty check`; main's `tests/type_checking` hook keeps its own id so both stay addressable. - reflex_base logging: main's move from `console` to stdlib `logging` wins in decorator.py, tasks.py and types.py, keeping the branch's `callable_name` for names a `Callable` does not statically have. - vars/base.py: `field()`'s overloads keep main's `FIELD_TYPE` / `Field[FIELD_TYPE]` return types rather than the branch's `Any`; main's `tests/type_checking/fields.py` asserts them. - istate/proxy.py: main's `_dataclass_proxy_namespace` plus the wrapt-stubs cast in `__new__`, which ty needs as well. - scripts/release.py: deleted, as on main. Type checking is clean after converting main's new `pyright: ignore` and `type: ignore` comments to the ty rules ty actually reports.

greptile-apps · 2026-09-21T23:05:15Z

Confidence Score: 4/5

[Medium impact] The migration reaches type-check workflows and shared Reflex code.

Fix the chart dependency floor and remove the duplicate compiler check before merging.

Findings

Charts fail with allowed dependency ▶
Compiler repeats a component check ▶

Summary

Replaces Pyright with ty across development hooks, contributor commands, and minimum-dependency checks.

Repository type checks now run with ty.
Callable names and state lookups now cover more inputs.
Generated class stubs keep fields with defaults optional.

_{Reviews (7) · Last reviewed commit: "Regenerate pyi hashes after the upstream..." · Reviewed by Greptile}

`scripts/check_min_deps.py` still shelled out to `pyright`, which this branch removed from the dev dependencies, so every `check-min-deps` job died with `FileNotFoundError: 'pyright'` before checking anything. It now runs `ty check --python <isolated venv> --output-format concise` and diffs the parsed error lines, with the rule severities copied out of the root `[tool.ty.rules]` into the `ty.toml` that `--config-file` supplies, so the isolated runs stay comparable to the repo-wide check. ty resolves more of the older releases than pyright did, so several packages now report deltas against their declared `reflex-base` floors. Those floors are genuinely behind the `field()` signature the components use; raising them is left to a separate change.

Conflict resolutions of note: - pyproject.toml: main's `[tool.pyright] extraPaths` stays dropped; its `packages/reflex-workflow` entry, which the workflow examples import from, becomes `[tool.ty.environment] extra-paths`. - scripts/check_min_deps.py: main's workspace wheelhouse and per-module invocation, run through ty; the per-module test now inspects the ty command. - vars/base.py and state.py: main's descriptor-backed fields and attribute access win; `_update_substate_vars` keeps the branch's `Mapping` parameter, and the mixin copy keeps the `FunctionType` guard on `fget`. - istate/proxy.py: `ImmutableMutableProxy._self_state` stays annotated as `StateProxy`, so main's cast in `_dirty_state` is dropped. - reflex/constants/custom_components.py: deleted, as on main. Type checking is clean after converting main's new `pyright: ignore` and `type: ignore` comments to the ty rules ty actually reports, and ignoring ty's stricter `**` unpacking checks in main's new tests.

greptile-apps · 2026-10-02T21:37:36Z

Comments Outside Diff

These findings could not be posted inline.

Context-aware defaults break migrations reflex/model.py:428 ▶

When a newly added model column has a callable default that uses SQLAlchemy's execution context, migration generation calls it with None. A default that reads context.get_current_parameters() then raises an exception, so the migration cannot be generated.

Conflicts keep upstream's refactors (proxy class cache, Var.to, redis state writes, file locks, Python 3.11 floor) with the branch's ty changes reapplied on top: pyright ignores dropped, ComputedVar.__get__ takes upstream's `instance: Any` with the branch's `owner: type[BaseState]`, reflex.model keeps SQLModelConfig beside upstream's lazy AsyncSession import. With 3.10 gone, the explicit ty python-version setting is dropped. New ty diagnostics in upstream code are fixed: the wrapt 2.5 wrapper takes an args tuple, the frontend shutdown flag is annotated bool, _cache_per_class names fn through callable_name, and the playground types its chart size dict and checks for a str before the filter membership test. Upstream pyright ignores that ty also reports became ty ignores, and ignores made unused by the fixed-arity EventCallback overloads are gone.

rx.Var.create(1).to(int) is a ToOperation, so the LiteralVar check missed it and get_var_value raised instead of returning 1.

format.py now imports console at module level, which closes an import cycle through log and decorator, so decorator.py imports callable_name where it is used. The new frozenset/set type forms in figure_out_type and the deprecated format_data_editor_column test call get ty ignores like their neighbours.

greptile-apps · 2026-10-21T20:22:50Z

 from reflex_base.constants import EventTriggers
 from reflex_base.constants.colors import Color
 from reflex_base.event import EventHandler, no_args_event_spec
+from reflex_base.utils.format import callable_name


Charts fail with allowed dependency

charts.py now imports callable_name, but reflex-components-recharts still allows reflex-base >= 0.10.0. That release lacks this helper, so users with that supported version get an ImportError when loading chart components. Raise the dependency floor to the first version containing the helper. The repository guide also requires raising sibling dependency floors when using unreleased changes.

Context Used: AGENTS.md (source)

greptile-apps · 2026-10-21T20:22:50Z

+    if isinstance(component, Component):
+        return component
    if (converted := _into_component_once(component)) is not None:
        return converted


Compiler repeats a component check

into_component() now checks for Component immediately before _into_component_once() performs the same check. Callable page inputs therefore pass the same check twice. The repository guide says not to repeat checks or add runtime workarounds for type-only problems. Remove this duplicate branch before merging to satisfy that requirement.

Suggested change

if isinstance(component, Component):

return component

if (converted := _into_component_once(component)) is not None:

return converted

if (converted := _into_component_once(component)) is not None:

return converted

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

benedikt-bartscher added 11 commits April 28, 2026 22:30

initial migration

2243535

improve typing

394ead6

update pyi

66d3326

some typing stuff

08231d5

do it like stdlib does for dataclasses

b57afce

fix type confusion

6f36c66

fix some more type ignores

d16d057

even more typing fixes

501b351

bump ty

f7bfd25

Merge remote-tracking branch 'upstream/main' into migrate-pyright-to-ty

1da8a7f

ruff format

fabfba2

benedikt-bartscher added 18 commits May 24, 2026 00:05

Merge remote-tracking branch 'upstream/main' into migrate-pyright-to-ty

28ac1e1

bump ty, adjust some typing

c8c4dff

pyi

6a4b3b7

fix import

7e6578f

less type ignores

3ce9c63

some more typing stuff

64734b9

eliminate more type ignores

d39f7c7

add passthrough_event_spec overload

440e7b6

re-add docs

a10eff7

fix docs

114e076

revert docs

0e31f36

less type ignores

7db7e00

pre-commit

d6713fa

more typing

3d4589f

use future annotations

b2867cc

drop pyright ignores, use final

3ac5147

more final, less ignore

1c52796

benedikt-bartscher added 13 commits May 30, 2026 00:38

drop type ignores

bc89a87

streamline signature assignment

15d26b4

add callable_qualname

2510a90

remove double ignores

16a3c8d

Merge remote-tracking branch 'upstream/main' into migrate-pyright-to-ty

3225280

bump ty

582bf98

fix some typing

b5ba90c

Merge remote-tracking branch 'upstream/main' into migrate-pyright-to-ty

39969fe

ty adjustments for new code from main

d696a65

typing wip

e7475eb

Merge remote-tracking branch 'origin/main' into migrate-pyright-to-ty

0833064

wip

3475185

greptile-apps Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread pyproject.toml

masenf added the perf Performance-improving changes label Sep 29, 2026

greptile-apps Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread reflex/state.py Outdated

benedikt-bartscher added 4 commits October 21, 2026 09:09

Read literal values through cast wrappers in get_var_value

eeec9cc

rx.Var.create(1).to(int) is a ToOperation, so the LiteralVar check missed it and get_var_value raised instead of returning 1.

Merge remote-tracking branch 'upstream/main' into migrate-pyright-to-ty

c5c0b35

Regenerate pyi hashes after the upstream merge

bbd2deb

greptile-apps Bot reviewed Oct 21, 2026

View reviewed changes

Navigation Menu

Repository navigation

tentative migrate pyright to ty - #6465

tentative migrate pyright to ty#6465
benedikt-bartscher wants to merge 49 commits into
reflex-dev:mainfrom
benedikt-bartscher:migrate-pyright-to-ty

benedikt-bartscher commented May 6, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented May 6, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 2, 2026

Uh oh!

Uh oh!

greptile-apps Bot Oct 21, 2026

Uh oh!

greptile-apps Bot Oct 21, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

benedikt-bartscher commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

greptile-apps Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 2, 2026

Comments Outside Diff

Uh oh!

Uh oh!

greptile-apps Bot Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benedikt-bartscher commented May 6, 2026 •

edited

Loading

codspeed Bot commented May 6, 2026 •

edited

Loading

greptile-apps Bot commented Sep 21, 2026 •

edited

Loading