Repository navigation
some typing nits - #6722
some typing nits#6722benedikt-bartscher wants to merge 3 commits into
Conversation
 [Low impact] The PR appears safe to merge; no actionable defects were found. SummaryThis PR tightens types and cleans up two tests without an established behavior regression.
No actionable new issues were found. Tests were not run. Reviews (3) · Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." · Reviewed by Greptile |
Merging this PR will not alter performance
|
| if isinstance(plugin, Mapping) and "import" in plugin | ||
| if not isinstance(plugin, str) and "import" in plugin |
There was a problem hiding this comment.
i dont like this one because it's a runtime check. despite the static typing, if this plugin object is not a str, it could be anything else and indexing into it with a str would be invalid. hence, checking if it's explicitly a Mapping makes the in check and subsequent __getitem__ call safe.
what was the motivation for this change? i might be misreading it.
# Conflicts: # packages/reflex-base/src/reflex_base/plugins/shared_tailwind.py # packages/reflex-base/src/reflex_base/vars/base.py # tests/units/test_state.py
No description provided.