Add mixin resolution to state lookup and token handling by benedikt-bartscher · Pull Request #6873 · reflex-dev/reflex

benedikt-bartscher · 2026-08-11T23:05:03Z

greptile-apps · 2026-08-11T23:07:13Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge, with no new actionable issues found.

Summary

Adds mixin lookup through RegistrationContext, get_state(), and state-manager tokens.

State mixins now resolve to the concrete state that uses them.

_{Reviews (13) · Last reviewed commit: "Flush the oplock lease in the mixin toke..." · Reviewed by Greptile}

…in/mixin-registration-context # Conflicts: # packages/reflex-base/src/reflex_base/registry.py # tests/units/reflex_base/test_registry.py # tests/units/test_state.py

codspeed · 2026-09-21T22:56:36Z

Merging this PR will not alter performance

1 warning

⚠️ 16 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 148 untouched benchmarks

_{Comparing benedikt-bartscher:mixin-registration-context (9618a3f) with main (656e8c7)}

…context

cubic-dev-ai

All reported issues were addressed across 7 files

_{Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic}

cubic-dev-ai

No issues found across 7 files

_{View guided diff | Re-trigger cubic}

…context

Use the shared state_manager fixture, which closes the manager on teardown and runs the tests against the memory, disk and redis backends.

…context

… import With oplock enabled, modify_state keeps the write in the lease cache while get_state reads Redis, so the test read the state back before the write was flushed.

wip

28d0813

benedikt-bartscher added 2 commits August 12, 2026 19:06

state api sugar.

b324ae4

Merge commit '006543ab32d53be0e245bababfa9b0b8c016c1fe' into merge-ma…

b8fbb44

…in/mixin-registration-context # Conflicts: # packages/reflex-base/src/reflex_base/registry.py # tests/units/reflex_base/test_registry.py # tests/units/test_state.py

Merge remote-tracking branch 'upstream/main' into mixin-registration-…

d7ddebe

…context

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread packages/reflex-base/src/reflex_base/registry.py

Merge remote-tracking branch 'upstream/main' into mixin-registration-…

3f44aa5

…context

benedikt-bartscher changed the title ~~wip improved mixin apis~~ Add mixin resolution to state lookup and token handling Oct 8, 2026

benedikt-bartscher marked this pull request as ready for review October 8, 2026 20:15

benedikt-bartscher requested a review from a team as a code owner October 8, 2026 20:15

Add news fragments for resolving state mixins

1b61221

cubic-dev-ai Bot reviewed Oct 8, 2026

View reviewed changes

Comment thread tests/units/test_state.py Outdated

cubic-dev-ai Bot reviewed Oct 8, 2026

View reviewed changes

benedikt-bartscher and others added 5 commits October 8, 2026 22:39

Merge remote-tracking branch 'upstream/main' into mixin-registration-…

61a883d

…context

Close the state manager in the mixin token tests

61f52cd

Use the shared state_manager fixture, which closes the manager on teardown and runs the tests against the memory, disk and redis backends.

Merge branch 'main' into mixin-registration-context

ac71de3

Merge branch 'main' into mixin-registration-context

40ebcf5

Merge branch 'main' into mixin-registration-context

3faffa9

greptile-apps Bot reviewed Oct 17, 2026

View reviewed changes

Comment thread reflex/state.py Outdated

benedikt-bartscher added 3 commits October 20, 2026 22:38

Merge remote-tracking branch 'upstream/main' into mixin-registration-…

6c64f90

…context

Drop the redundant RegistrationContext import in get_state

284a304

Flush the oplock lease in the mixin token test and hoist the registry…

9618a3f

… import With oplock enabled, modify_state keeps the write in the lease cache while get_state reads Redis, so the test read the state back before the write was flushed.

Navigation Menu

Repository navigation

Add mixin resolution to state lookup and token handling - #6873

Add mixin resolution to state lookup and token handling#6873
benedikt-bartscher wants to merge 14 commits into
reflex-dev:mainfrom
benedikt-bartscher:mixin-registration-context

benedikt-bartscher commented Aug 11, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

greptile-apps Bot commented Aug 11, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

benedikt-bartscher commented Aug 11, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

codspeed Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

benedikt-bartscher commented Aug 11, 2026 •

edited by cubic-dev-ai Bot

Loading

greptile-apps Bot commented Aug 11, 2026 •

edited

Loading

codspeed Bot commented Sep 21, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading