Skip to content

Use 0.10.0 as the router cookie deprecation version - #7523

Merged
masenf merged 1 commit into
mainfrom
claude/funny-cerf-ynbx20
Oct 8, 2026
Merged

masenf merged 1 commit into
mainfrom
claude/funny-cerf-ynbx20

Conversation

@masenf

@masenf masenf commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

The State.router.headers.cookie deprecation added in #7360 passes deprecation_version="0.9.13", but it first ships in the 0.10 release line (latest tag v0.10.0a5). This PR changes it to "0.10.0".

It's a one-line change in reflex/istate/data.py. tests/units/istate/test_data.py passes and ruff is clean.

There's no news fragment. This corrects a change that hasn't been released yet, and the existing news/+router-cookie-privacy.deprecation.md doesn't mention a version, so it's still accurate. The PR needs the skip-changelog label.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XGbR9efAcf7RNMMqU7JLY8


Generated by Claude Code

View guided diff Turn on auto-fix

The State.router.headers.cookie deprecation added in #7360 shipped in the
0.10 alpha line, so the warning should name 0.10.0 rather than 0.9.13.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XGbR9efAcf7RNMMqU7JLY8
@masenf
masenf requested a review from a team as a code owner October 8, 2026 20:12
@masenf masenf added the skip-changelog For doc/internal changes label Oct 8, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Changes the deprecation version for State.router.headers.cookie from 0.9.13 to 0.10.0.

  • Keeps the empty-string fallback and removal version unchanged.
  • No actionable issues found.
  • masenf intentionally omitted a new news fragment because the existing entry covers this unreleased change.

Reviews (1) · Last reviewed commit: "Use 0.10.0 as the router cookie deprecat..." · Reviewed by Greptile

@masenf
masenf merged commit 85da007 into main Oct 8, 2026
143 of 144 checks passed
@masenf
masenf deleted the claude/funny-cerf-ynbx20 branch October 8, 2026 20:15
@codspeed

codspeed Bot commented Oct 8, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 7.12%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 148 untouched benchmarks
⏩ 18 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_hydration_metadata[200] 2 ms 1.8 ms +9.15%
⚡ test_hydration_metadata[20] 218.9 µs 208.2 µs +5.13%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/funny-cerf-ynbx20 (dd01ddc) with main (beef0ae)

Open in CodSpeed

Footnotes

  1. 18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants