Repository navigation
fix: parenthesize a unary base in the compiled ** expression #7565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FarhanAliRaza
merged 6 commits into
reflex-dev:main
from
darshjoshi:fix-negative-exponent-base
Oct 22, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1b63beb
fix: parenthesize a unary base in the compiled ** expression
darshjoshi 47af713
Add a news fragment
darshjoshi d297ce9
Move the exponent test next to the other reflex_base.vars tests
darshjoshi 2150318
Keep test_var.py as it is on the base branch
darshjoshi 945b916
Merge branch 'main' into fix-negative-exponent-base
masenf 3e82720
Merge branch 'main' into fix-negative-exponent-base
FarhanAliRaza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Raising a negative number or a negated var to a power, such as `(-State.x) ** 2`, now compiles to valid JavaScript instead of failing the frontend build with "A unary expression with the '-' operator cannot be used as the left operand of an exponentiation expression". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| """Tests for reflex_base.vars.number.""" | ||
|
|
||
| from reflex_base.vars.base import Var | ||
| from reflex_base.vars.number import LiteralNumberVar | ||
|
|
||
|
|
||
| def test_exponent_parenthesizes_a_unary_base(): | ||
| """JavaScript rejects a unary expression as the base of `**` (`-2 ** 2` is a SyntaxError).""" | ||
| x = Var(_js_expr="x").to(int) | ||
| assert str(LiteralNumberVar.create(-2) ** 3) == "((-2) ** 3)" | ||
| assert str(LiteralNumberVar.create(-2.5) ** x) == "((-2.5) ** x)" | ||
| assert str((-x) ** 2) == "((-(x)) ** 2)" | ||
| assert str(-(x**2)) == "-((x ** 2))" | ||
| assert str(x**-1) == "(x ** -1)" | ||
| assert str(2**-x) == "(2 ** -(x))" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.