Repository navigation
fix: bound JSON output shutdown after interrupt - #7578
harsh21234i wants to merge 11 commits into
Conversation
[Medium impact] The changes since the previous review appear safe to merge. SummaryThis PR adds a shutdown deadline for JSON output and shortens oversized records written during shutdown.
Reviews (9) · Last reviewed commit: "fix(logging): preserve records in interr..." · Reviewed by Greptile |
Merging this PR will not alter performance1 warning
Comparing |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
Main now includes #7558, which deliberately keeps the child in the supervisor's process group so terminal Ctrl-Z and a process-group SIGKILL still reach the app (review rationale). This PR's A mechanical conflict resolution would either reintroduce the orphaned-child behavior or discard this PR's bounded shutdown behavior. The bounded drain needs to be reconciled with the shared-process-group behavior before a safe main merge. I have left the branch intact for that author/reviewer decision. |
4df572a to
f44613c
Compare
Summary
Tests
tests/units/reflex_base/utils/test_log.py: 81 passed, 5 skipped on Windows (POSIX-only cases).git diff --checkpassed.Fixes #7510