Repository navigation
Conversation
Contributor
[Low impact] The PR appears safe to merge. SummaryFixes static typing for
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "Fix static typing for set and frozenset ..." · Reviewed by Greptile |
masenf
reviewed
Oct 22, 2026
masenf
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for preparing this patch.
We're going to hold off for the moment, because set wasn't really supported at all in 0.10 and prior, and we're trying to figure out if we should represent it with a javascript Set and expose set operations as methods instead of just treating it like an array.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix static typing for
setandfrozensetarray vars so literal creation preserves container types and indexing returns theappropriate element var type.
Sequence component-prop runtime behavior is unchanged.
All Submissions
Type of change
Changes To Core Features
Validation
Related to ENG-13480; surfaced in the review of #7622.
Closes #7623