[gaurav0107]

All Submissions:

• Have you followed the guidelines stated in CONTRIBUTING.md file?
• Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

• Bug fix (non-breaking change which fixes an issue)

Description

StateManagerDisk.load_state() caught every exception and returned None, so an existing state file that could not be loaded was handled like a missing one. get_state() started from a fresh state and the next write replaced the file, and nothing was logged.

This PR keeps the return value (still None, so the app keeps working from a fresh state, as the redis manager does on a mismatch) but makes the failure visible:

• File that cannot be read or unpickled (bad pickle bytes, truncated or empty file, a pickle referencing a missing module, IO errors): a warning that names the token and file path, with the traceback.
• Stored schema no longer matches the state class (StateSchemaMismatchError with no chained cause): a debug record. This is an expected reset after editing a state class in dev, and a warning here would fire for every stale substate after each edit.
• Missing file: unchanged, no log.

BaseState._deserialize also raises StateSchemaMismatchError for unpickling failures, but chains the original error, so a mismatch counts as an expected reset only when it has no chained cause.

I kept this to logging and didn't add a new exception or quarantine the file, because the issue doesn't settle the recovery behavior. If you'd prefer to raise, or to move the unreadable file aside before it gets overwritten, I can change it.

Closes #7167

Changes To Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Testing

New tests in tests/units/istate/manager/test_disk.py. All of them fail on main:

• missing file: load_state returns None and logs nothing
• unreadable file (b"not-a-pickle" and an empty file for both a plain StateToken and a BaseStateToken, plus a pickle that references a missing module): one WARNING that names the token and path and carries exc_info, and get_state still returns a fresh state
• stale schema (a valid pickle whose stored schema doesn't match): one DEBUG record, no warning, and get_state returns defaults

Commands run:

• uv run pytest tests/units/istate/manager: 75 passed
• uv run pytest tests/units --cov --no-cov-on-fail --cov-report=: the only 3 failures also fail on main in my environment (two dataeditor tests need node, one reflex_bench HMR port test)
• uv run pre-commit run --files <changed files> (ruff format/check, codespell, pyright, ty): all pass

---

🤖 Opened with Superhuman, an open-source contribution agent.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The disk state manager now reports failed loads without changing how it starts from fresh state.

• Disk state load failures now show up in the logs.

No new actionable issues were found. No previous review threads were supplied.

_{Reviews (2) · Last reviewed commit: "fix(state): warn on any disk state file ..." · Reviewed by Greptile}

[codspeed]

Merging this PR will regress 1 benchmark

2 warnings

⚠️ 9 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 146 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌	test_get_state_uncached[memory]	8.1 ms	8.5 ms	-4.48%
⚡	test_route_argument_extraction	120.6 µs	114.5 µs	+5.31%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing gaurav0107:fix/7167-statemanagerdisk-silently-resets-corrupt (bf6cee2) with main (be0c685)}

[cubic-dev-ai]

All reported issues were addressed across 3 files

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic</sub>