Repository navigation
Revert "fix(vars): accept a frozenset as an array literal" (#7622) - #7632
Conversation
This reverts commit 54c9aa6. Treating a set or frozenset as an ArrayVar is the wrong direction: sets are not sequences, and the operations users want on them (membership, add, union) are not array operations. A dedicated SetVar backed by the JS Set object is tracked in #7623 instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RnswbLCA27Ku2CxbJs58d
[Medium impact] The PR appears safe to merge. SummaryReverts the unreleased support for treating
No actionable new issues were found. Reviews (2) · Last reviewed commit: "Merge branch 'main' into claude/project-..." · Reviewed by Greptile |
Merging this PR will not alter performance1 warning
Comparing |
|
CodSpeed reports a -4.69% regression on Generated by Claude Code |
Requested by Masen · project thread
Type of change
Description
Reverts #7622, which registered
frozensetonArrayVaralongsidesetso a frozen set literal rendered as a JS array.Treating a
setas anArrayVaris the wrong direction. A set is not a sequence, and the operations a user wants on one (membership, add, remove, union, intersection) are not array operations. Rather than widening the array types further, sets should get their ownSetVarbacked by the JSSetobject; that is now tracked in #7623.Net effect after the revert is the pre-#7622 state:
frozensetis rejected byLiteralVar.create, andsetis still routed toArrayVaras before. #7622 was never released, so there is no changelog entry.Related: #7623
Generated by Claude Code