Skip to content

Fix dark-mode contrast in foreach documentation examples - #7657

Open
carlosabadia wants to merge 1 commit into
mainfrom
carlos/fix-foreach-dark-mode
Open

carlosabadia wants to merge 1 commit into
mainfrom
carlos/fix-foreach-dark-mode

Conversation

@carlosabadia

@carlosabadia carlosabadia commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

The foreach documentation uses fixed light backgrounds and black grid borders, leaving the todo text unreadable and number-cell borders difficult to see in dark mode. Use theme colors for the backgrounds, text, and borders so both examples follow the active color mode.

Validation

  • Built and inspected the production docs preview in dark mode.
  • Existing foreach docgen regression check passes (test_docgen_double_eval.py -k foreach).
  • Ruff lint, formatting, and git diff --check pass.

Before and after

Before After
Before: low-contrast todo content in dark mode After: theme-aware todo content in dark mode

Closes ENG-13556.

@carlosabadia
carlosabadia requested review from a team and Alek99 as code owners October 26, 2026 10:08
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Oct 26, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change affects the appearance of two examples in the foreach documentation.

The color changes look sound, but the repository requires a regression test before merging.

Findings

  1. P2 Color fix lacks regression coverage ▶

Summary

The foreach examples now use theme colors instead of fixed light backgrounds and black borders.

  • The foreach examples use theme colors in both color modes.

Reviews (1) · Last reviewed commit: "Fix dark-mode contrast in foreach docume..." · Reviewed by Greptile

Comment thread docs/library/dynamic-rendering/foreach.md
@linear-code

linear-code Bot commented Oct 26, 2026

Copy link
Copy Markdown

ENG-13556

@codspeed

codspeed Bot commented Oct 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 14 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 148 untouched benchmarks


Comparing carlos/fix-foreach-dark-mode (d9a9ce0) with main (656e8c7)

Open in CodSpeed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants