Repository navigation
Fix dark-mode contrast in foreach documentation examples - #7657
Open
carlosabadia wants to merge 1 commit into
Open
carlosabadia wants to merge 1 commit into
carlosabadia wants to merge 1 commit into
Conversation
Contributor
[Low impact] The change affects the appearance of two examples in the foreach documentation. The color changes look sound, but the repository requires a regression test before merging. Findings
SummaryThe foreach examples now use theme colors instead of fixed light backgrounds and black borders.
Reviews (1) · Last reviewed commit: "Fix dark-mode contrast in foreach docume..." · Reviewed by Greptile |
Merging this PR will not alter performance1 warning
Comparing |
FarhanAliRaza
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The foreach documentation uses fixed light backgrounds and black grid borders, leaving the todo text unreadable and number-cell borders difficult to see in dark mode. Use theme colors for the backgrounds, text, and borders so both examples follow the active color mode.
Validation
test_docgen_double_eval.py -k foreach).git diff --checkpass.Before and after
Closes ENG-13556.