Feat/tools/parallel execute #2036
Conversation
📝 WalkthroughWalkthroughIntroduces a new Changes
Sequence Diagram(s)sequenceDiagram
participant LLM as LLM/Agent
participant ToolNode as Tool Node
participant Tool1 as Tool 1
participant Tool2 as Tool 2
participant ToolN as Tool N
LLM->>ToolNode: invoke with tool_calls array
par Parallel Execution
ToolNode->>Tool1: execute concurrently
ToolNode->>Tool2: execute concurrently
ToolNode->>ToolN: execute concurrently
end
Tool1-->>ToolNode: result + index
Tool2-->>ToolNode: result + index
ToolN-->>ToolNode: result + index (or error)
ToolNode->>ToolNode: sort results by original index
ToolNode->>ToolNode: construct ToolMessage array
ToolNode-->>LLM: ordered tool results for context
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/skill-template/src/skills/agent.ts (1)
285-287: Minor: Line length exceeds 100 characters.Line 286 is 113 characters, exceeding the project's 100-character limit. Consider breaking it into multiple lines.
♻️ Suggested formatting
- this.engine.logger.info( - `Executing ${toolCalls.length} tool calls in parallel: [${toolCalls.map((tc) => tc?.name).join(', ')}]`, - ); + const toolNames = toolCalls.map((tc) => tc?.name).join(', '); + this.engine.logger.info( + `Executing ${toolCalls.length} tool calls in parallel: [${toolNames}]`, + );As per coding guidelines, the maximum line length is 100 characters.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/api/src/modules/config/app.config.tsapps/api/src/modules/drive/drive.service.tspackages/skill-template/src/skills/agent.ts
🧰 Additional context used
📓 Path-based instructions (15)
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{js,ts,jsx,tsx}: Always use optional chaining (?.) when accessing object properties
Always use nullish coalescing (??) or default values for potentially undefined values
Always check array existence before using array methods
Always validate object properties before destructuring
Always use single quotes for string literals in JavaScript/TypeScript code
**/*.{js,ts,jsx,tsx}: Use semicolons at the end of statements
Include spaces around operators (e.g.,a + binstead ofa+b)
Always use curly braces for control statements
Place opening braces on the same line as their statement
**/*.{js,ts,jsx,tsx}: Group import statements in order: React/framework libraries, third-party libraries, internal modules, relative path imports, type imports, style imports
Sort imports alphabetically within each import group
Leave a blank line between import groups
Extract complex logic into custom hooks
Use functional updates for state (e.g.,setCount(prev => prev + 1))
Split complex state into multiple state variables rather than single large objects
Use useReducer for complex state logic instead of multiple useState calls
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{js,ts,tsx,jsx,py,java,cpp,c,cs,rb,go,rs,php,swift,kt,scala,r,m,mm,sql}
📄 CodeRabbit inference engine (.cursor/rules/00-language-priority.mdc)
**/*.{js,ts,tsx,jsx,py,java,cpp,c,cs,rb,go,rs,php,swift,kt,scala,r,m,mm,sql}: All code comments MUST be written in English
All variable names, function names, class names, and other identifiers MUST use English words
Comments should be concise and explain 'why' rather than 'what'
Use proper grammar and punctuation in comments
Keep comments up-to-date when code changes
Document complex logic, edge cases, and important implementation details
Use clear, descriptive names that indicate purpose
Avoid abbreviations unless they are universally understood
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/00-language-priority.mdc)
Use JSDoc style comments for functions and classes in JavaScript/TypeScript
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/01-code-style.mdc)
**/*.{js,jsx,ts,tsx}: Use single quotes for string literals in TypeScript/JavaScript
Always use optional chaining (?.) when accessing object properties in TypeScript/JavaScript
Always use nullish coalescing (??) or default values for potentially undefined values in TypeScript/JavaScript
Always check array existence before using array methods in TypeScript/JavaScript
Validate object properties before destructuring in TypeScript/JavaScript
Use ES6+ features like arrow functions, destructuring, and spread operators in TypeScript/JavaScript
Avoid magic numbers and strings - use named constants in TypeScript/JavaScript
Use async/await instead of raw promises for asynchronous code in TypeScript/JavaScript
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/03-typescript-guidelines.mdc)
**/*.{ts,tsx}: Avoid usinganytype whenever possible - useunknowntype instead with proper type guards
Always define explicit return types for functions, especially for public APIs
Prefer extending existing types over creating entirely new types
Use TypeScript utility types (Partial<T>,Pick<T, K>,Omit<T, K>,Readonly<T>,Record<K, T>) to derive new types
Use union types and intersection types to combine existing types
Always import types explicitly using theimport typesyntax
Group type imports separately from value imports
Minimize creating local type aliases for imported types
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{js,ts,jsx,tsx,css,json}
📄 CodeRabbit inference engine (.cursor/rules/04-code-formatting.mdc)
Maximum line length of 100 characters
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{js,ts,jsx,tsx,css,json,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/04-code-formatting.mdc)
Use 2 spaces for indentation, no tabs
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{js,ts,jsx,tsx,css,json,yml,yaml,md}
📄 CodeRabbit inference engine (.cursor/rules/04-code-formatting.mdc)
No trailing whitespace at the end of lines
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{css,scss,sass,less,js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/09-design-system.mdc)
**/*.{css,scss,sass,less,js,jsx,ts,tsx}: Primary color (#155EEF) should be used for main brand color in buttons, links, and accents
Error color (#F04438) should be used for error states and destructive actions
Success color (#12B76A) should be used for success states and confirmations
Warning color (#F79009) should be used for warnings and important notifications
Info color (#0BA5EC) should be used for informational elements
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{tsx,ts}
📄 CodeRabbit inference engine (.cursor/rules/09-i18n-guidelines.mdc)
**/*.{tsx,ts}: Use the translation wrapper component and useTranslation hook in components
Ensure all user-facing text is translatable
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{tsx,ts,json}
📄 CodeRabbit inference engine (.cursor/rules/09-i18n-guidelines.mdc)
Support dynamic content with placeholders in translations
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{tsx,ts,jsx,js,vue,css,scss,less}
📄 CodeRabbit inference engine (.cursor/rules/11-ui-design-patterns.mdc)
**/*.{tsx,ts,jsx,js,vue,css,scss,less}: Use the primary blue (#155EEF) for main UI elements, CTAs, and active states
Use red (#F04438) only for errors, warnings, and destructive actions
Use green (#12B76A) for success states and confirmations
Use orange (#F79009) for warning states and important notifications
Use blue (#0BA5EC) for informational elements
Primary buttons should be solid with the primary color
Secondary buttons should have a border with transparent or light background
Danger buttons should use the error color
Use consistent padding, border radius, and hover states for all buttons
Follow fixed button sizes based on their importance and context
Use consistent border radius (rounded-lg) for all cards
Apply light shadows (shadow-sm) for card elevation
Maintain consistent padding inside cards (p-4orp-6)
Use subtle borders for card separation
Ensure proper spacing between card elements
Apply consistent styling to all form inputs
Use clear visual indicators for focus, hover, and error states in form elements
Apply proper spacing between elements using 8px, 16px, 24px increments
Ensure proper alignment of elements (left, center, or right)
Use responsive layouts that work across different device sizes
Maintain a minimum contrast ratio of 4.5:1 for text
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{tsx,ts,jsx,js,vue}
📄 CodeRabbit inference engine (.cursor/rules/11-ui-design-patterns.mdc)
**/*.{tsx,ts,jsx,js,vue}: Include appropriate loading states for async actions in buttons
Group related form elements with appropriate spacing
Provide clear validation feedback for forms
Ensure proper labeling and accessibility for form elements
Ensure all interactive elements are keyboard accessible
Include appropriate ARIA attributes for complex components
Provide alternative text for images and icons
Support screen readers with semantic HTML elements
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/08-contributing-guidelines.mdc)
**/*.{ts,tsx,js,jsx}: Follow the TypeScript/JavaScript style guidelines
Ensure code is well-tested and documented
Files:
apps/api/src/modules/config/app.config.tspackages/skill-template/src/skills/agent.tsapps/api/src/modules/drive/drive.service.ts
apps/api/src/**/*.{controller,service}.ts
📄 CodeRabbit inference engine (.cursor/rules/06-api-structure.mdc)
Implement proper error handling in API modules
Files:
apps/api/src/modules/drive/drive.service.ts
🧠 Learnings (1)
📚 Learning: 2025-12-25T06:26:57.096Z
Learnt from: nettee
Repo: refly-ai/refly PR: 1942
File: packages/skill-template/src/skills/agent.ts:159-169
Timestamp: 2025-12-25T06:26:57.096Z
Learning: In packages/skill-template/src/skills/agent.ts, the supportToolChoice capability check uses `!== false` rather than `=== true` by design to maintain backward compatibility. Models without the supportToolChoice field defined (undefined) should still receive tool_choice: 'auto', and only models explicitly marked as supportToolChoice: false should skip the parameter.
Applied to files:
packages/skill-template/src/skills/agent.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build / Build
🔇 Additional comments (5)
packages/skill-template/src/skills/agent.ts (2)
273-384: Excellent implementation of parallel tool execution!The enhanced tool node successfully executes multiple tool calls concurrently while maintaining order and providing comprehensive error handling. Key strengths:
- Uses
Promise.allfor concurrent execution (line 353)- Preserves original order by tracking indices and sorting results (lines 356-358)
- Returns structured
ToolMessageobjects for all cases (success, missing tool, empty name, execution failure)- Adds detailed logging for observability
The approach will significantly improve performance when multiple tools are invoked simultaneously.
290-350: Well-structured error handling for parallel execution.Each tool call scenario is properly handled:
- Empty tool names → Returns structured error ToolMessage
- Missing tools → Returns "tool not available" ToolMessage
- Execution failures → Returns error ToolMessage with details
- Successful execution → Returns content ToolMessage
The consistent return structure
{index, message}enables proper ordering after parallel execution completes.apps/api/src/modules/config/app.config.ts (1)
306-307: LGTM! Clean configuration addition.The new
lambda.s3.inputBucketproperty follows the established pattern with a sensible fallback chain (LAMBDA_INPUT_S3_BUCKET → MINIO_INTERNAL_BUCKET → default). This standardizes S3 bucket configuration and aligns with the usage indrive.service.ts.apps/api/src/modules/drive/drive.service.ts (2)
676-680: LGTM! Consistent use of new S3 bucket configuration.The change correctly separates input and output bucket configuration using:
lambda.s3.inputBucketfor source fileslambda.s3.bucketfor Lambda outputBoth properties have defaults defined in
app.config.ts, ensuring the values are always available.
1394-1395: Consistent S3 bucket configuration across all Lambda dispatches.All Lambda dispatch methods (
triggerAsyncParse,dispatchLambdaImageTransform,dispatchLambdaDocumentRender,startExportJob) consistently use the new configuration keys for input and output buckets. This standardization improves maintainability and aligns with the configuration changes inapp.config.ts.Also applies to: 2313-2314, 2369-2370, 2477-2478
This pull request makes two main improvements: it updates the configuration and usage of S3 input/output buckets throughout the backend, and it enhances the agent skill template to execute tool calls in parallel rather than sequentially. The configuration changes ensure consistency and flexibility for specifying S3 buckets, while the agent update improves performance by running tool calls concurrently.
Configuration and S3 Bucket Handling:
lambda.s3.inputBucketthroughout the codebase, replacing older references toobjectStorage.minio.internal.bucketand hardcoded defaults. This affects both the app configuration (app.config.ts) and all Lambda dispatch logic indrive.service.ts. [1] [2] [3] [4] [5] [6]Agent Skill Tool Call Execution:
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.